Skip to content

London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Wireframe#1426

Closed
codebyra wants to merge 14 commits into
CodeYourFuture:mainfrom
codebyra:feature/wireframe
Closed

London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Wireframe#1426
codebyra wants to merge 14 commits into
CodeYourFuture:mainfrom
codebyra:feature/wireframe

Conversation

@codebyra

@codebyra codebyra commented Jun 8, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist
I replaced the placeholder content with structured semantic HTML and added the three required articles, each containing a unique image, title, summary, and link. I also improved accessibility by including descriptive alt text and ensured the layout followed the wireframe specifications.

This PR completes the wireframe task by adding the HTML structure, CSS grid layout, accessibility improvements, and validation fixes.

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module failed. Why did it fail? →

Name Link
🔨 Latest commit 502b044
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a27926c5cba48000804c0bf

@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026
@codebyra codebyra changed the title London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Feature/wireframe London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Wireframe Jun 8, 2026
@codebyra

codebyra commented Jun 8, 2026

Copy link
Copy Markdown
Author

@cjyuan please can you review my work?

@cjyuan

cjyuan commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
  • To better match the wireframe, position the page title to match its position in the wireframe. There should also be a "short description" beneath the title.

  • Can you update the images and links to meet a requirement that the articles should have distinct images and links?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 8, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also restore the "Changelist" header in the PR description? It's a level 2 header that looks like this:

Changelist


Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically
clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing
formatting-only changes, making it easier to review the actual code changes.

For more info about enabling "Format on save" option on VS Code, please refer to this guide.


@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@codebyra codebyra closed this Jun 9, 2026
@codebyra codebyra deleted the feature/wireframe branch June 9, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants