Skip to content

Add an error message to controld_sched_timeout() so the fatal error i…#4116

Merged
nrwahl2 merged 1 commit into
ClusterLabs:mainfrom
thomas-jones-ibm:add-error-message-to-controld-sched-timeout
May 27, 2026
Merged

Add an error message to controld_sched_timeout() so the fatal error i…#4116
nrwahl2 merged 1 commit into
ClusterLabs:mainfrom
thomas-jones-ibm:add-error-message-to-controld-sched-timeout

Conversation

@thomas-jones-ibm
Copy link
Copy Markdown
Contributor

…sn't a mystery

@knet-jenkins
Copy link
Copy Markdown

knet-jenkins Bot commented May 21, 2026

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/pacemaker/job/pacemaker-pipeline/job/PR-4116/1/input

@nrwahl2
Copy link
Copy Markdown
Contributor

nrwahl2 commented May 21, 2026

retest this please

@nrwahl2
Copy link
Copy Markdown
Contributor

nrwahl2 commented May 21, 2026

@thomas-jones-ibm Thanks for the patch!

Can you please rebase your branch on the current main branch, and then push again? The CI test failures are from calls to deprecated libxml2 functions -- but we removed those functions a while back.

@thomas-jones-ibm thomas-jones-ibm force-pushed the add-error-message-to-controld-sched-timeout branch from 4659340 to 3661863 Compare May 22, 2026 15:47
@knet-jenkins
Copy link
Copy Markdown

knet-jenkins Bot commented May 22, 2026

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/pacemaker/job/pacemaker-pipeline/job/PR-4116/3/input

@thomas-jones-ibm
Copy link
Copy Markdown
Contributor Author

@nrwahl2 done

@nrwahl2
Copy link
Copy Markdown
Contributor

nrwahl2 commented May 25, 2026

retest this please

@nrwahl2
Copy link
Copy Markdown
Contributor

nrwahl2 commented May 25, 2026

(previous comment is a directive that gets picked up by our CI system)

@nrwahl2
Copy link
Copy Markdown
Contributor

nrwahl2 commented May 25, 2026

Hi, Thomas. We actually deprecated crm_err a while back and replaced it with pcmk__err. I didn't notice that your patch used crm_err at first; that's the cause of the most recent CI failure. Can you update one more time to change it to pcmk__err?

I think we should be good at that point. This is just a one-line logging patch, after all ;)

@thomas-jones-ibm thomas-jones-ibm force-pushed the add-error-message-to-controld-sched-timeout branch from 3661863 to e7a855b Compare May 27, 2026 07:21
@knet-jenkins
Copy link
Copy Markdown

knet-jenkins Bot commented May 27, 2026

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/pacemaker/job/pacemaker-pipeline/job/PR-4116/5/input

@thomas-jones-ibm
Copy link
Copy Markdown
Contributor Author

thomas-jones-ibm commented May 27, 2026

@nrwahl2 Done!

I was originally looking at Pacemaker 2.1.6 while tracking a problem down, and just rebased the change so that's why it was crm_err() This seemed to be the only place in all of pacemaker that could have ended up with controld exiting with status 100 without a prior message that would explain why.

@nrwahl2 nrwahl2 merged commit f402c9b into ClusterLabs:main May 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants