update dependencies, don't statically link openssl#120
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned vcpkg baseline/commit and changes the build to avoid statically linking OpenSSL, relying on the host OpenSSL at runtime to prevent symbol interposition issues and allow distro CVE patching.
Changes:
- Bump vcpkg baseline/commit pin across config, CI action, and Docker build.
- Update vcpkg Linux PIC triplets to build the
opensslport as a shared library while keeping other deps static. - Add linker option to hide symbols from static archives in the produced extension (
--exclude-libs,ALL) to reduce RTLD_GLOBAL symbol interposition.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vcpkg-configuration.json | Updates the vcpkg registry baseline commit. |
| triplets/x64-linux-pic.cmake | Switches OpenSSL to dynamic linkage for this triplet. |
| triplets/arm64-linux-pic.cmake | Switches OpenSSL to dynamic linkage for this triplet. |
| INSTALL.md | Updates installation/runtime dependency statement for OpenSSL. |
| docker/postgres-ext.Dockerfile | Pins vcpkg commit and installs runtime OpenSSL package (libssl3). |
| CMakeLists.txt | Adds linker option to hide static-archive symbols from dynamic export. |
| .github/actions/setup-vcpkg/action.yml | Pins vcpkg commit for CI to keep binary cache stable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
serprex
force-pushed
the
update-dependencies
branch
2 times, most recently
from
5f194c1 to
f442360
Compare
JoshDreamland
approved these changes
Jul 14, 2026
JoshDreamland
left a comment
JoshDreamland
left a comment
Contributor
There was a problem hiding this comment.
Seems fine on both counts.
static openssl was getting overridden by postgres openssl anyways
serprex
force-pushed
the
update-dependencies
branch
from
f442360 to
d768dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static openssl was getting overridden by postgres openssl anyways