Faster package-init: Add opt-out uv installer for package-init.sh's Python packages#14
Open
gdrc-swastik wants to merge 1 commit into
Open
Conversation
pip's resolver takes noticeably longer than uv's on the Python package list (numpy/pandas/scipy/opencv/etc.), which matters for anyone rebuilding the packages PVC/Job in CI or a fresh local cluster. PYTHON_PACKAGE_INSTALLER defaults to "uv" and installs the same package list with uv instead (pinned via UV_VERSION, default 0.11.26). Setting it to "pip" preserves existing behavior exactly. Verified locally (arm64 Docker): both paths complete the full Python + Node + Bun + Bash init successfully. As with any unpinned "latest compatible" install, resolved versions for unconstrained packages can differ between runs and installers — that's inherent to the existing unpinned package list, not introduced by this change.
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip's resolver takes noticeably longer than uv's on the Python package list (numpy/pandas/scipy/opencv/etc.), which matters for anyone rebuilding the packages PVC/Job in CI or a fresh local cluster.
On my dev machine (Mac), what took pip 20+ min was done by uv in <5min.
PYTHON_PACKAGE_INSTALLER defaults to "uv" and installs the same package list with uv instead (pinned via UV_VERSION, default 0.11.26). Setting it to "pip" preserves existing behavior exactly.
Verified locally (arm64 Docker): both paths complete the full Python + Node + Bun + Bash init successfully. As with any unpinned "latest compatible" install, resolved versions for unconstrained packages can differ between runs and installers - that's inherent to the existing unpinned package list, not introduced by this change.