You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Repository collaborators can run the JMH benchmark suite against this PR by commenting:
/benchmark
Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%):
/benchmark threshold=15
Only one benchmark run per PR is active at a time — issuing a new /benchmark comment cancels the previous run. After the run finishes a separate comment will be posted comparing it against the latest scheduled run on main; the PR check fails if any benchmark regresses by more than the threshold.
Summary
This PR removes the in-repo JMH benchmark infrastructure that was apparently superseded by the stresshouse benchmark workflow added in a prior PR. Deleted items include: compare-jmh.py (~588-line Python comparison script), test_compare_jmh.py, all associated test-data fixtures, benchmarks.yml (the JMH runner workflow triggered by /benchmark slash commands or daily schedule), and benchmarks-pr-comment.yml (the PR instruction poster). The only additive change is in stresshouse-benchmark-compare.yml: the external shared-workflow reference is pinned from @main to a specific SHA (51b1407ab4b67f37333823f2c43aa42f0d9da141), and secrets: inherit is replaced with two explicitly named secrets (WORKFLOW_AUTH_PUBLIC_APP_ID, WORKFLOW_AUTH_PUBLIC_PRIVATE_KEY).
What this impacts
.github/workflows/ — two benchmark workflows removed; one stresshouse workflow updated
.github/scripts/ — JMH comparison tooling and all test fixtures deleted
PR benchmark trigger (/benchmark slash command) is permanently removed
Concerns
GitHub workflow changes rule fires (medium):stresshouse-benchmark-compare.yml is modified — explicit secret keys replace secrets: inherit; if the calling workflow expects more secrets than the two explicitly forwarded, benchmark runs will silently fail.
Test-infra scope reduction (medium): removing benchmarks.yml eliminates the daily scheduled JMH benchmark baseline on main. If the stresshouse replacement is not fully equivalent, there is no fallback benchmark CI.
Large diff: 1,464 lines changed (5 added, 1,459 deleted), technically exceeding the 400-line high-risk threshold. However, virtually all lines are pure deletions of coherent, self-contained benchmark tooling, keeping actual review complexity low. Flagged for awareness, not escalation.
No linked issue; the body only references a "followup PR" without a number.
Required reviewer action
At least one human reviewer should confirm the stresshouse workflow's explicit secret list is complete and that benchmark coverage is not regressed by removing the JMH scheduled baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup PR to added stresshouse-benchmark WF
Checklist
Delete items not relevant to your PR: