refactor(server): break cfstore.py into recceiver/cf/ subpackage#160
Open
anderslindho wants to merge 12 commits intomasterfrom
Open
refactor(server): break cfstore.py into recceiver/cf/ subpackage#160anderslindho wants to merge 12 commits intomasterfrom
anderslindho wants to merge 12 commits intomasterfrom
Conversation
simon-ess
approved these changes
May 8, 2026
Contributor
simon-ess
left a comment
simon-ess
left a comment
There was a problem hiding this comment.
Seems an improvement to me!
jacomago
approved these changes
May 8, 2026
Also fixes the hardcoded "iocid" string literal to CFPropertyName.IOC_ID.
CFProcessor now speaks domain types at every callsite with no raw dict handling. mock_client.py is removed.
Extract _setup_cf_properties, _apply_env_vars, _register_aliases, _remove_aliases, and _process_new_channels to bring all five flagged (by Sonar) methods within the complexity threshold.
anderslindho
force-pushed
the
refactor-cf-subpackage
branch
from
537b40a to
9133c8a
Compare
Fix _merge_property_lists mutable default argument — safe in practice since the set is only read, but still wrong form.
anderslindho
force-pushed
the
refactor-cf-subpackage
branch
2 times, most recently
from
cbb100f to
321fedc
Compare
anderslindho
force-pushed
the
refactor-cf-subpackage
branch
from
321fedc to
c89d65e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behaviour changes.