Fail loudly on max output token reached error#20
Open
naftali-g wants to merge 1 commit into
Open
Conversation
jtoman
requested changes
May 28, 2026
Contributor
jtoman
left a comment
jtoman
left a comment
There was a problem hiding this comment.
Nope, as discussed on slack; this is too coarse. Claude will sometimes exhaust its token limit while thinking, and graphcore will correct that without problem (the default conversation node implementation). It's far better to intercept the error thrown by pydantic in this case (missing field) and make that the "go down in flames" path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we just go into a loop where the agent tries generating the same (too-long) response over and over.