docs: add Monitor architecture decision record#224
Open
somethingwithproof wants to merge 3 commits into
Open
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Drop code-quality workflow and php-cs-fixer scaffolding that would gate merges without a format pass. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial architecture documentation describing a proposed incremental migration of the Monitor plugin toward a hexagonal (ports/adapters) architecture, and links it from the README.
Changes:
- Add a new ADR documenting proposed hexagonal boundaries, state concepts, and a staged migration plan.
- Add an “Architecture” section to the README linking to the ADR.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Adds a link to the new ADR from the project README. |
| docs/architecture/0001-hexagonal-monitor.md | Introduces ADR-0001 describing the proposed target architecture and migration plan. |
Comment on lines
+37
to
+39
| Domain code must not access request variables, sessions, globals, SQL, the | ||
| filesystem, or Cacti helper functions. New code must remain PHP 7.4-compatible | ||
| until Cacti changes its supported baseline. |
Member
|
The discussion I would like with this one is to deprecate monitor in 1.3 by merging it into develop as we've done with 18+ other plugins. Same with audit. |
Member
|
@bmfmancini and @xmacan, comments? |
Member
|
I agree we could merge monitor into core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the initial proposed ADR for an incremental, PHP 7.4-compatible migration of Monitor toward a hexagonal architecture.
Covers
host.monitor_*fieldsImpact
Documentation only; no current Monitor behavior changes.