Skip to content

fix(test): e2e me 쿼리 mock 에 account_identities 추가#125

Merged
chanwoo7 merged 1 commit into
developfrom
fix/e2e-me-mock-account-identities
Jun 3, 2026
Merged

fix(test): e2e me 쿼리 mock 에 account_identities 추가#125
chanwoo7 merged 1 commit into
developfrom
fix/e2e-me-mock-account-identities

Conversation

@chanwoo7
Copy link
Copy Markdown
Member

@chanwoo7 chanwoo7 commented Jun 3, 2026

Summary

develop 에서 상시 실패하던 e2e 테스트(GraphQL me는 인증이 통과되어야 한다)를 고칩니다. 프로덕션 버그가 아니라 테스트 mock 결함입니다.

toMePayloadaccount.account_identities.map(...) 로 연동 소셜 계정을 매핑하는데(소셜 provider 노출 기능), e2e 의 mockUserRepository.findAccountWithProfileaccount_identities 를 반환하지 않아 Cannot read properties of undefined (reading 'map') 로 깨지고 있었습니다. mock 에 account_identities: [] 를 추가해 실제 repository 반환 형태와 맞춥니다.

Scope

변경

  • test/app.e2e-spec.tsmockUserRepository.findAccountWithProfile 의 반환 객체에 account_identities: [] 추가

프로덕션 코드 변경 없음. 테스트 mock 한 줄.

Impact

  • FE / DB / 프로덕션: 영향 없음 (테스트 전용).
  • CI: e2e 7개 전부 통과 (이전 1개 실패 → 0).

Test plan

  • yarn test:e2e — 7/7 통과
  • CI 통과 확인

toMePayload 가 account_identities.map 을 호출하는데 e2e mock 의
findAccountWithProfile 반환값에 해당 필드가 없어 상시 실패하던 것을 해소.
mock 을 실제 repository 반환 형태에 맞춰 account_identities: [] 추가.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ca8ad856-21a8-47ae-bffa-abcb1e696f05

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-me-mock-account-identities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.36% 3542/3638
🟢 Branches 93.84% 1128/1202
🟢 Functions 93.77% 647/690
🟢 Lines 97.59% 3242/3322

Test suite run success

1240 tests passing in 144 suites.

Report generated by 🧪jest coverage report action from 56d04e5

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chanwoo7 chanwoo7 merged commit b9b8148 into develop Jun 3, 2026
10 checks passed
@chanwoo7 chanwoo7 deleted the fix/e2e-me-mock-account-identities branch June 3, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant