Skip to content

Prevent the mapping of objects with a data length of 0 bytes #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trojanobelix wants to merge 2 commits into
base: main
Choose a base branch
from
+7,081 −42
Open

Prevent the mapping of objects with a data length of 0 bytes #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b56baae
Prevent the mapping of objects with a data length of 0 bytes
trojanobelix May 31, 2026
9b2cf86
[ROOT][DOCS] contrib-readme-action has updated readme
github-actions[bot] May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions EDSEditorGUI/DevicePDOView2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,12 @@ public void UpdatePDOinfo(bool updatechoices = true)
MessageBox.Show(string.Format("Invalid TXPDO mapping parameters in 0x{0:X}!\r\nTrying to map more than the maximum lenght of a CAN message (8 bytes).\r\n\r\nMembers are:\r\n{1}", slot.ConfigurationIndex,toDisplay));
break;
}
if ((bitoff + mappingentry.width) <= 0)
{
string toDisplay = string.Join(Environment.NewLine, slot.Mapping);
MessageBox.Show(string.Format("Invalid TXPDO mapping parameters in 0x{0:X}!\r\nTrying to map less than the minimum lenght of a CAN message (0 bytes).\r\n\r\nMembers are:\r\n{1}", slot.ConfigurationIndex, toDisplay));
break;
}
string target = slot.getTargetName(mappingentry.entry);
grid1[row + 2, bitoff + INFO_COLS_COUNT] = new SourceGrid.Cells.Cell(target, comboStandard);
grid1[row + 2, bitoff + INFO_COLS_COUNT].ColumnSpan = mappingentry.width;
Expand Down
56 changes: 14 additions & 42 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,27 +87,6 @@ Collaborators
<table>
<tbody>
<tr>
<td align="center">
<a href="https://github.com/robincornelius">
<img src="https://avatars.githubusercontent.com/u/159000?v=4" width="100;" alt="robincornelius"/>
<br />
<sub><b>robincornelius</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/nimrof">
<img src="https://avatars.githubusercontent.com/u/9848846?v=4" width="100;" alt="nimrof"/>
<br />
<sub><b>nimrof</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/CANopenNode">
<img src="https://avatars.githubusercontent.com/u/13575344?v=4" width="100;" alt="CANopenNode"/>
<br />
<sub><b>CANopenNode</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/trojanobelix">
<img src="https://avatars.githubusercontent.com/u/15106425?v=4" width="100;" alt="trojanobelix"/>
Expand Down Expand Up @@ -170,13 +149,6 @@ Contributors
</td>
</tr>
<tr>
<td align="center">
<a href="https://github.com/reza0310">
<img src="https://avatars.githubusercontent.com/u/70545529?v=4" width="100;" alt="reza0310"/>
<br />
<sub><b>reza0310</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/heliochronix">
<img src="https://avatars.githubusercontent.com/u/1733202?v=4" width="100;" alt="heliochronix"/>
Expand All @@ -192,10 +164,10 @@ Contributors
</a>
</td>
<td align="center">
<a href="https://github.com/cfr-mir">
<img src="https://avatars.githubusercontent.com/u/44053860?v=4" width="100;" alt="cfr-mir"/>
<a href="https://github.com/cfrank-mir">
<img src="https://avatars.githubusercontent.com/u/284268463?v=4" width="100;" alt="cfrank-mir"/>
<br />
<sub><b>cfr-mir</b></sub>
<sub><b>cfrank-mir</b></sub>
</a>
</td>
<td align="center">
Expand All @@ -211,6 +183,13 @@ Contributors
<br />
<sub><b>gotocoffee1</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/reza0310">
<img src="https://avatars.githubusercontent.com/u/70545529?v=4" width="100;" alt="reza0310"/>
<br />
<sub><b>reza0310</b></sub>
</a>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -249,22 +228,15 @@ Contributors
<sub><b>Regelink</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/DylanRobertBennett">
<img src="https://avatars.githubusercontent.com/u/87715493?v=4" width="100;" alt="DylanRobertBennett"/>
<br />
<sub><b>DylanRobertBennett</b></sub>
</a>
</td>
</tr>
<tr>
<td align="center">
<a href="https://github.com/rgruening">
<img src="https://avatars.githubusercontent.com/u/72022918?v=4" width="100;" alt="rgruening"/>
<br />
<sub><b>rgruening</b></sub>
</a>
</td>
</tr>
<tr>
<td align="center">
<a href="https://github.com/Barzello">
<img src="https://avatars.githubusercontent.com/u/52344726?v=4" width="100;" alt="Barzello"/>
Expand Down Expand Up @@ -300,15 +272,15 @@ Contributors
<sub><b>DaMutz</b></sub>
</a>
</td>
</tr>
<tr>
<td align="center">
<a href="https://github.com/StormOli">
<img src="https://avatars.githubusercontent.com/u/4819887?v=4" width="100;" alt="StormOli"/>
<br />
<sub><b>StormOli</b></sub>
</a>
</td>
</tr>
<tr>
<td align="center">
<a href="https://github.com/possibly-not">
<img src="https://avatars.githubusercontent.com/u/12588174?v=4" width="100;" alt="possibly-not"/>
Expand Down
Loading
Loading