Fix WAL file-handle leak in disk store recovery#89
Open
sven-n wants to merge 1 commit into
Open
Conversation
RecoverFromWalOrIndex in both BasicDiskVocabularyStore and
BasicDiskVectorStore opened the WAL file with `using var fs`, which
keeps the handle alive until the end of the method. The subsequent
File.WriteAllBytes(_walPath, ...) call then raced against that handle
on Windows and threw IOException("The process cannot access the file
... because it is being used by another process."), causing
AddAndGetText_PersistsToDisk and Delete_RemovesFromIndexButKeepsFile to
fail intermittently.
Scope the FileStream/BinaryReader in an explicit `using (...)` block so
they are disposed before the truncating write.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecoverFromWalOrIndexin bothBasicDiskVocabularyStoreandBasicDiskVectorStoreopened the WAL withusing var fs = …, whose scope extends to method end. The subsequentFile.WriteAllBytes(_walPath, …)then raced against the still-open handle and threwIOException("The process cannot access the file '…wal' because it is being used by another process.")on Windows.FileStream/BinaryReaderin an explicitusing (…)block so they are disposed before the truncating write.Test plan
SharpVectorTest.DiskVectorDatabaseTests.AddAndGetText_PersistsToDiskpasses (previously failed with the IOException above)SharpVectorTest.DiskVectorDatabaseTests.Delete_RemovesFromIndexButKeepsFilepasses (previously failed with the same IOException)dotnet test src/SharpVectorTest) — 66/66 green on this branch🤖 Generated with Claude Code