Skip to content

support for jQuery 4#377

Closed
reiern70 wants to merge 1 commit into
BorisMoore:masterfrom
reiern70:reiern70/jquery-4.0.0
Closed

support for jQuery 4#377
reiern70 wants to merge 1 commit into
BorisMoore:masterfrom
reiern70:reiern70/jquery-4.0.0

Conversation

@reiern70
Copy link
Copy Markdown

@reiern70 reiern70 commented Jun 3, 2026

@BorisMoore I guess I'm missing to generate the minimized file.

@BorisMoore
Copy link
Copy Markdown
Owner

Thanks, but yes minified files need also to be generated.

See also: #375 (comment)

Because of the way JsRender and JsViews are built, I will need to make the changes in the jsviews.com repository, and then 'propogate' the changes to jsrender.js, jquery,views.js, jquery.observable.js, and jsviews.js, through the build process. The build prcocess also uses gulp to create the minified files.

@reiern70 reiern70 force-pushed the reiern70/jquery-4.0.0 branch from fd482a3 to 6116746 Compare June 4, 2026 14:19
@reiern70
Copy link
Copy Markdown
Author

reiern70 commented Jun 4, 2026

Thanks, but yes minified files need also to be generated.

See also: #375 (comment)

Because of the way JsRender and JsViews are built, I will need to make the changes in the jsviews.com repository, and then 'propogate' the changes to jsrender.js, jquery,views.js, jquery.observable.js, and jsviews.js, through the build process. The build prcocess also uses gulp to create the minified files.

I did minimize the files... I'm testing this in the context of wicketstuff/core#1477 and our application that uses Apache wicket and jQuery 4

@BorisMoore
Copy link
Copy Markdown
Owner

Thanks for working on this, but I wanted to let you know that I won't actually merge your pull request, since I have to follow the build process mentioned above. (Using the jsviews.com repository, and updating not only the jsrender project but also the jsviews project, and providing updates to jsrender. js, jsviews.js, jquery.observable.js and jquery.views.js.)

See https://www.jsviews.com/#download

I am currently working on providing a full update across all those files, (as well as tne Node.js version of JsRender) with jQuery 4 support.

@ernestosemedy
Copy link
Copy Markdown

ernestosemedy commented Jun 4, 2026

Thanks for working on this, but I wanted to let you know that I won't actually merge your pull request, since I have to follow the build process mentioned above. (Using the jsviews.com repository, and updating not only the jsrender project but also the jsviews project, and providing updates to jsrender. js, jsviews.js, jquery.observable.js and jquery.views.js.)

See https://www.jsviews.com/#download

I am currently working on providing a full update across all those files, (as well as tne Node.js version of JsRender) with jQuery 4 support.

I understand. My PR served me to test changes on my application and all seems to work ok.

@ernestosemedy
Copy link
Copy Markdown

One question. I see jsrender was published at some time as a web jar... would it be possible to do so again?

@reiern70
Copy link
Copy Markdown
Author

reiern70 commented Jun 4, 2026

Closing the PR. @BorisMoore thanks!

@reiern70 reiern70 closed this Jun 4, 2026
@reiern70
Copy link
Copy Markdown
Author

reiern70 commented Jun 4, 2026

One question. I see jsrender was published at some time as a web jar... would it be possible to do so again?

https://mvnrepository.com/artifact/org.webjars.bowergithub.borismoore/jsrender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants