support for jQuery 4#377
Conversation
|
Thanks, but yes minified files need also to be generated. See also: #375 (comment) Because of the way JsRender and JsViews are built, I will need to make the changes in the jsviews.com repository, and then 'propogate' the changes to jsrender.js, jquery,views.js, jquery.observable.js, and jsviews.js, through the build process. The build prcocess also uses gulp to create the minified files. |
2b485c4 to
fd482a3
Compare
fd482a3 to
6116746
Compare
I did minimize the files... I'm testing this in the context of wicketstuff/core#1477 and our application that uses Apache wicket and jQuery 4 |
|
Thanks for working on this, but I wanted to let you know that I won't actually merge your pull request, since I have to follow the build process mentioned above. (Using the jsviews.com repository, and updating not only the jsrender project but also the jsviews project, and providing updates to jsrender. js, jsviews.js, jquery.observable.js and jquery.views.js.) See https://www.jsviews.com/#download I am currently working on providing a full update across all those files, (as well as tne Node.js version of JsRender) with jQuery 4 support. |
I understand. My PR served me to test changes on my application and all seems to work ok. |
|
One question. I see jsrender was published at some time as a web jar... would it be possible to do so again? |
|
Closing the PR. @BorisMoore thanks! |
https://mvnrepository.com/artifact/org.webjars.bowergithub.borismoore/jsrender |
@BorisMoore I guess I'm missing to generate the minimized file.