Contains minor improvements and code clean-up across several files.

[jamespepper81]

This pull request contains minor improvements and code clean-up across several files. The changes focus on clarifying type usage, improving code readability, and removing redundant imports.

Type and import improvements:

• Changed the declaration of requiredFunctions in wallet-setup.tsx to use a more concise type syntax, improving readability.
• Cleaned up imports in components/AnimatedNumber.tsx by removing a redundant TextInput import and grouping it with other React Native imports.

Code readability:

• Added an ESLint directive in receive.tsx to prevent unnecessary dependency warnings in the useEffect hook, clarifying intent for future maintainers.

[Copilot]

Pull request overview

This pull request attempts to improve code consistency and readability through type syntax updates and import consolidation. However, it introduces an inconsistency in type declaration syntax and adds an ESLint directive without following the established documentation convention.

Changes:

• Consolidated TextInput import in AnimatedNumber.tsx from a separate line to the main react-native import statement
• Changed type syntax for requiredFunctions in wallet-setup.tsx from Array<keyof WalletService> to (keyof WalletService)[]
• Added ESLint directive in receive.tsx to suppress exhaustive-deps warning

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
components/AnimatedNumber.tsx	Consolidates TextInput import with other react-native imports for better organization
app/wallet-setup.tsx	Changes array type syntax from Array to T[] notation
app/(tabs)/receive.tsx	Adds ESLint directive to disable exhaustive-deps rule

[Copilot]

The ESLint directive is missing an explanatory comment. According to the codebase convention (see app/(tabs)/send.tsx:253-254 and app/passkeys-security.tsx:38-39), when adding eslint-disable-next-line react-hooks/exhaustive-deps, you should include a comment explaining why dependencies are intentionally omitted. For example, you could add a comment like "// walletService is intentionally omitted as it's stable" on the dependency array line.

Suggested change

	}, [currentWallet?.xpub, currentWallet?.addresses?.length]);
	}, [currentWallet?.xpub, currentWallet?.addresses?.length]); // walletService and stable setters/callbacks are intentionally omitted to avoid unnecessary refetch loops

[Copilot]

This change introduces inconsistency with the existing codebase. The file utils/wallet-service-loader.ts:61 uses Array for the same pattern. For consistency, this should remain as Array rather than changing to (keyof WalletService)[]. While both syntaxes are valid TypeScript, consistency across the codebase is important for maintainability.

Suggested change

	const requiredFunctions: (keyof WalletService)[] = ['generateMnemonic', 'validateMnemonic', 'createWallet', 'importWallet'];
	const requiredFunctions: Array<keyof WalletService> = ['generateMnemonic', 'validateMnemonic', 'createWallet', 'importWallet'];