Update the native module imports in the iOS implementation of @react-native-firebase/crashlytics#494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the native module imports in the iOS implementation of
@react-native-firebase/crashlyticsto improve compatibility with different versions of React Native. The changes ensure that the correct header files are imported depending on the project setup, which helps prevent build issues across React Native versions.Compatibility improvements for React Native versions:
RNFBCrashlyticsModule.hto conditionally import either<React-Core/RCTBridgeModule.h>or<React/RCTBridgeModule.h>based on availability, ensuring compatibility with both newer and older React Native setups.RNFBCrashlyticsModule.mto conditionally import React Native headers (RCTConvert.h,RCTLog.h,RCTUtils.h) from either<React-Core/>or<React/>, depending on which is available, for better support across React Native versions.