Ensure debug.keystore is ignored and fix conflicting documentation#467
Merged
Conversation
- Added clarifying comments to .gitignore patterns for keystore files - Added *.keystore pattern to android/.gitignore for defense-in-depth - Updated KEYSTORE_FILES.md documentation to clarify that debug.keystore is NOT tracked in version control - Fixed misleading documentation that suggested debug.keystore should be committed Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…o-gitignore Ensure debug.keystore is ignored and fix conflicting documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation and gitignore configuration to improve keystore file security and clarity for Android development. The main changes ensure that no keystore files, including the debug keystore, are ever committed to version control, and provide developers with clear instructions for local keystore generation.
Keystore file exclusion and documentation updates:
android/.gitignoreto explicitly excludedebug.keystoreand all*.keystorefiles, preventing accidental commits of sensitive key material.docs/KEYSTORE_FILES.mdto clarify that no keystore files are tracked in version control, including the debug keystore, and that each developer must generate their own locally. [1] [2]keytool, and explained that Android Studio/Gradle will auto-generate one if missing..gitignoredocumentation to show explicit exclusion of all keystore files and removed the previous exception for the debug keystore.android/.gitignorefiles.