Refactor transaction-explorer: fix zero-value handling, simplify fee logic, and optimize address Set creation#440
Merged
Merged
Conversation
- Add memoization for wallet address Set to improve performance - Rename userWallet parameter to currentWallet for consistency - Simplify fee handling logic - Fix vin.value condition to properly handle zero values - Remove unnecessary blank lines Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
The previous implementation compared a normalized array which would always create a new reference. Now comparing the original addresses reference for proper memoization. Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
Allow the cache to properly handle both null and undefined by storing the exact reference without normalizing to undefined. Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…ameter-names Refactor transaction-explorer: fix zero-value handling, simplify fee logic, and optimize address Set creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces performance improvements and minor code quality enhancements to the
app/transaction-explorer.tsxfile, primarily by memoizing the wallet address set and making small adjustments to variable naming and value handling. The main focus is to optimize address set creation and improve code clarity.Performance optimizations:
getAddressSetto avoid recreating the wallet addressSeton every call, improving efficiency when determining wallet-related addresses.getAddressSetinstead of creating a newSetinline when building transaction explorer data.Code quality and clarity:
userWalletparameter tocurrentWalletin thebuildExplorerDatafunction for improved clarity and consistency.vin.valueis a number before performing arithmetic operations.txDetails.feewith a fallback to zero, removing redundant type checking.Other minor changes: