Skip to content

Fix server-side request forgery code scanning alert #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamespepper81 merged 2 commits into from
May 27, 2026
Merged

Fix server-side request forgery code scanning alert #718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c53d96e
Potential fix for code scanning alert no. 12: Server-side request for…
jamespepper81 May 27, 2026
e261d58
Merge pull request #717 from BitSleuthAI/alert-autofix-12
jamespepper81 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/lib/blockchain-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,21 @@ export async function fetchJson(
revalidate?: number,
): Promise<any> {
const origin = TRUSTED_ORIGINS[host];

const hostPathPolicies = ALLOWED_PATHS[host];
if (!hostPathPolicies || !hostPathPolicies.some((rx) => rx.test(pathname))) {
throw new Error('Disallowed provider URL path.');
}

const url = new URL(pathname, origin);

if (query) {
for (const [key, value] of Object.entries(query)) {
url.searchParams.set(key, value);
}
}

const hostPathPolicies = ALLOWED_PATHS[host];
const canonicalPathname = url.pathname;
const hasDotSegments = canonicalPathname.split('/').some((segment) => segment === '.' || segment === '..');
if (hasDotSegments || !hostPathPolicies || !hostPathPolicies.some((rx) => rx.test(canonicalPathname))) {
throw new Error('Disallowed provider URL path.');
}

if (url.origin !== origin || url.protocol !== 'https:') {
throw new Error('URL construction resulted in an unexpected origin.');
}
Expand Down
Loading