Fix SSRF allowlist and refactor allowed hosts to module scope#703
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… api.alternative.me The Copilot Autofix allowlist only included three hosts, but fetchJson() is also called with blockchain.info (BTC ticker) and api.alternative.me (Fear & Greed Index). Without these, address pages, wallet dashboard, and market page would throw "Disallowed provider URL" errors. Also moved the Set to module scope to avoid re-creating it on every call. https://claude.ai/code/session_01SKn49yBtsK4JtGvpyfauqB
Refactor: Extract allowed hosts to module-level constant
Potential fix for code scanning alert no. 3: Server-side request forgery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.