chore: update async worker to use callbacks#237
Merged
Conversation
pranishnepal
force-pushed
the
follow-up/polling-worker-WCN-746
branch
from
1158850 to
d768aac
Compare
This commit refactors the async job worker to utilize callbacks for keychain creation and wallet addition. Ticket: WCN-746
pranishnepal
force-pushed
the
follow-up/polling-worker-WCN-746
branch
from
d768aac to
2b0166c
Compare
Comment on lines
+117
to
+118
| const result = await baseCoin.wallets().generateWallet({ | ||
| ...(job.request?.body ?? {}), |
Contributor
There was a problem hiding this comment.
how is the request body being type checked?
Contributor
Author
There was a problem hiding this comment.
this is what bridge sends back, which we would have validated when MBE was initially hit - because bridge <> mbe work with unknowns atm, we aren't able to set a specific typing 🤔
Contributor
There was a problem hiding this comment.
this isn't part of the callbacks, but I had a few questions on the async job worker too. I can leave the review here in a bit and pranish can make another followup if they need to be addressed
danielpeng1
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR refactors the async job worker to utilize callbacks for keychain creation and
wallet addition.
Ticket: WCN-746
Testing