-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: wallet generation handler to use new sdk callback #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+485
−258
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
153 changes: 153 additions & 0 deletions
153
src/__tests__/api/master/walletGenerationCallbacks.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| import 'should'; | ||
| import assert from 'assert'; | ||
| import nock from 'nock'; | ||
| import { | ||
| createAwmBackupClient, | ||
| createAwmClient, | ||
| AdvancedWalletManagerClient, | ||
| } from '../../../masterBitgoExpress/clients/advancedWalletManagerClient'; | ||
| import { createOnchainKeyGenCallback } from '../../../masterBitgoExpress/handlers/walletGenerationCallbacks'; | ||
| import { AppMode, KeySource, MasterExpressConfig, TlsMode } from '../../../shared/types'; | ||
| import { DEFAULT_ASYNC_MODE_CONFIG } from './testUtils'; | ||
|
|
||
| describe('walletGenerationCallbacks', () => { | ||
| const advancedWalletManagerUrl = 'http://advancedwalletmanager.invalid'; | ||
| const backupAwmUrl = 'http://backup-awm.invalid'; | ||
| const coin = 'tbtc'; | ||
|
|
||
| // Valid BIP32 extended public keys required by the SDK's isValidPub check | ||
| const validUserPub = | ||
| 'xpub661MyMwAqRbcFtXgS5sYJABqqG9YLmC4Q1Rdap9gSE8NqtwybGhePY2gZ29ESFjqJoCu1Rupje8YtGqsefD265TMg7usUDFdp6W1EGMcet8'; | ||
| const validBackupPub = | ||
| 'xpub661MyMwAqRbcGczjuMoRm6dXaLDEhW1u34gKenbeYqAix21mdUKJyuyu5F1rzYGVxyL6tmgBUAEPrEz92mBXjByMRiJdba9wpnN37RLLAXa'; | ||
|
|
||
| let awmUserClient: AdvancedWalletManagerClient; | ||
| let awmBackupClient: AdvancedWalletManagerClient; | ||
|
|
||
| function makeConfig(overrides: Partial<MasterExpressConfig> = {}): MasterExpressConfig { | ||
| return { | ||
| appMode: AppMode.MASTER_EXPRESS, | ||
| port: 0, | ||
| bind: 'localhost', | ||
| timeout: 60000, | ||
| httpLoggerFile: '', | ||
| env: 'test', | ||
| disableEnvCheck: true, | ||
| authVersion: 2, | ||
| advancedWalletManagerUrl, | ||
| awmServerCaCert: 'dummy-cert', | ||
| tlsMode: TlsMode.DISABLED, | ||
| clientCertAllowSelfSigned: true, | ||
| asyncModeConfig: DEFAULT_ASYNC_MODE_CONFIG, | ||
| ...overrides, | ||
| }; | ||
| } | ||
|
|
||
| before(() => { | ||
| nock.disableNetConnect(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| nock.cleanAll(); | ||
| }); | ||
|
|
||
| after(() => { | ||
| nock.enableNetConnect(); | ||
| }); | ||
|
|
||
| describe('createOnchainKeyGenCallback', () => { | ||
| describe('with separate backup AWM (separate-HSM mode)', () => { | ||
| beforeEach(() => { | ||
| const config = makeConfig({ advancedWalletManagerBackupUrl: backupAwmUrl }); | ||
| awmUserClient = createAwmClient(config, coin)!; | ||
| awmBackupClient = createAwmBackupClient(config, coin)!; | ||
| assert(awmUserClient); | ||
| assert(awmBackupClient); | ||
| }); | ||
|
|
||
| it('should route user source to the primary AWM client', async () => { | ||
| const userKeychainNock = nock(advancedWalletManagerUrl) | ||
| .post(`/api/${coin}/key/independent`, { | ||
| source: KeySource.USER, | ||
| }) | ||
| .reply(200, { | ||
| pub: validUserPub, | ||
| source: KeySource.USER, | ||
| type: 'independent', | ||
| }); | ||
|
|
||
| const callback = createOnchainKeyGenCallback(awmUserClient, awmBackupClient); | ||
| const result = await callback({ source: KeySource.USER, coin }); | ||
|
|
||
| result.pub.should.equal(validUserPub); | ||
| result.source.should.equal(KeySource.USER); | ||
| result.type.should.equal('independent'); | ||
| userKeychainNock.done(); | ||
| }); | ||
|
|
||
| it('should route backup source to the backup AWM client', async () => { | ||
| const backupKeychainNock = nock(backupAwmUrl) | ||
| .post(`/api/${coin}/key/independent`, { | ||
| source: KeySource.BACKUP, | ||
| }) | ||
| .reply(200, { | ||
| pub: validBackupPub, | ||
| source: KeySource.BACKUP, | ||
| type: 'independent', | ||
| }); | ||
|
|
||
| const callback = createOnchainKeyGenCallback(awmUserClient, awmBackupClient); | ||
| const result = await callback({ source: KeySource.BACKUP, coin }); | ||
|
|
||
| result.pub.should.equal(validBackupPub); | ||
| result.source.should.equal(KeySource.BACKUP); | ||
| result.type.should.equal('independent'); | ||
| backupKeychainNock.done(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('without separate backup AWM (same-HSM mode)', () => { | ||
| beforeEach(() => { | ||
| const config = makeConfig(); | ||
| awmUserClient = createAwmClient(config, coin)!; | ||
| awmBackupClient = createAwmBackupClient(config, coin) ?? awmUserClient; | ||
| assert(awmUserClient); | ||
| }); | ||
|
|
||
| it('should route backup source to the primary AWM client', async () => { | ||
| const backupKeychainNock = nock(advancedWalletManagerUrl) | ||
| .post(`/api/${coin}/key/independent`, { | ||
| source: KeySource.BACKUP, | ||
| }) | ||
| .reply(200, { | ||
| pub: validBackupPub, | ||
| source: KeySource.BACKUP, | ||
| type: 'independent', | ||
| }); | ||
|
|
||
| const callback = createOnchainKeyGenCallback(awmUserClient, awmBackupClient); | ||
| const result = await callback({ source: KeySource.BACKUP, coin }); | ||
|
|
||
| result.pub.should.equal(validBackupPub); | ||
| result.source.should.equal(KeySource.BACKUP); | ||
| result.type.should.equal('independent'); | ||
| backupKeychainNock.done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should throw for unexpected key sources', async () => { | ||
| const config = makeConfig({ advancedWalletManagerBackupUrl: backupAwmUrl }); | ||
| awmUserClient = createAwmClient(config, coin)!; | ||
| awmBackupClient = createAwmBackupClient(config, coin)!; | ||
| assert(awmUserClient); | ||
| assert(awmBackupClient); | ||
|
|
||
| const callback = createOnchainKeyGenCallback(awmUserClient, awmBackupClient); | ||
|
|
||
| await callback({ | ||
| source: KeySource.BITGO as 'user', | ||
| coin, | ||
| }).should.be.rejectedWith('Unexpected key source for onchain key generation: bitgo'); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a short test file for just wallet gen callbacks, avoids clogging up
generateWallet.test.ts