fix(sdk-core): skip keychain fetch in createAddress for OFC wallets#9014
Merged
zahin-mohammad merged 1 commit intoJun 12, 2026
Merged
Conversation
OFC coins never use keychains for address verification — isWalletAddress always throws MethodNotImplementedError and the check is skipped. Fetching all wallet keys was unnecessary and failed for wallets where a server-managed key at index 1 has no accessible keychain record in the OFC namespace. Fixes WCN-942 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
alextse-bg
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wallet.createAddress()was unconditionally fetching all wallet keys before creating an address, including server-managed keys at index 1 that have no accessible keychain record in the OFC namespaceisWalletAddressalways throwsMethodNotImplementedErrorand verification is skipped — so the fetch was unnecessarybaseCoin.getFamily() === 'ofc'Ticket: WCN-942