fix(sdk-coin-trx): allow TSS TRC20 consolidation when recipients absent#9002
Closed
bhavidhingra wants to merge 1 commit into
Closed
fix(sdk-coin-trx): allow TSS TRC20 consolidation when recipients absent#9002bhavidhingra wants to merge 1 commit into
bhavidhingra wants to merge 1 commit into
Conversation
TrxToken.verifyTransaction TSS path had two bugs: 1. Cast (txPrebuild.txInfo as TronTxInfo).recipients throws TypeError when txInfo is undefined (ECDSA signing call passes raw protobuf with no txInfo). Fixed with optional chaining. 2. Server TSS consolidation never populates recipients — trxTS.ts buildTokenTransacarsedTx.recipientsand prebuildConsolidaludes it. Guard now treats absent or empty recipients as consolidation, passing on valid ABI structure alone (Aptos pattern). Ticket: COINS-392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyTransactionTSS path crashed withTypeError: Cannot read properties of undefined (reading 'recipients')on the 3rd call — ECDSA signing passes raw protobuftxHexwith notxInfotrxTS.ts:buildTokenTransactionFromIntent) never populatesrecipientsinparsedTx; non-TSS path (trx.js:getBuildTransactionResult:313) does it explicitlytxInfo?.recipients+ treat absent/empty recipients as consolidation (skip intent match, pass on valid ABI structure alone — Aptos pattern)Test plan
ttrx:usdtTSSconsolidateAccountsucceeds end-to-endFixes COINS-392
🤖 Generated with Claude Code