Skip to content

feat: add eddsa MPCv2 SMC utils#8845

Merged
kisslove-dewangan merged 4 commits into
masterfrom
WCI-242-add-eddsa-mpcv2-smc-utils
May 29, 2026
Merged

feat: add eddsa MPCv2 SMC utils#8845
kisslove-dewangan merged 4 commits into
masterfrom
WCI-242-add-eddsa-mpcv2-smc-utils

Conversation

@kisslove-dewangan

Copy link
Copy Markdown
Contributor

TICKET: WCI-242

@kisslove-dewangan kisslove-dewangan requested review from a team as code owners May 25, 2026 12:51
@linear-code

linear-code Bot commented May 25, 2026

Copy link
Copy Markdown

WCI-242

@Marzooqa Marzooqa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall structure is correct — the 2-round key-gen flow (no round 3) is intentionally different from ECDSA because MPS EdDSA DKG only requires 2 BitGo rounds. uploadClientKeys is a faithful copy of the ECDSA version. Three issues below; one is a potential runtime failure on every call.

No tests added. The ECDSA MPCv2SMCUtils also has no unit tests, but this is still a gap — at minimum keyGenRound1BySender and keyGenRound2BySender should have state-assertion failure tests and a happy-path test using a stub sender.

Comment thread modules/sdk-core/src/bitgo/utils/tss/eddsa/SMC/utils.ts
Comment thread modules/sdk-core/src/bitgo/utils/tss/eddsa/SMC/utils.ts

@Marzooqa Marzooqa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

Comment thread modules/sdk-core/src/bitgo/utils/tss/eddsa/SMC/utils.ts Outdated
Comment thread modules/sdk-core/src/bitgo/utils/tss/eddsa/SMC/utils.ts
@kisslove-dewangan kisslove-dewangan requested a review from a team as a code owner May 26, 2026 10:05
@kisslove-dewangan kisslove-dewangan requested a deployment to breaking-changes-override May 26, 2026 10:14 — with GitHub Actions Waiting
@kisslove-dewangan kisslove-dewangan requested a deployment to breaking-changes-override May 26, 2026 10:34 — with GitHub Actions Waiting
@kisslove-dewangan kisslove-dewangan force-pushed the WCI-242-add-eddsa-mpcv2-smc-utils branch from e84788c to c51a674 Compare May 28, 2026 08:07
@kisslove-dewangan kisslove-dewangan temporarily deployed to breaking-changes-override May 28, 2026 08:16 — with GitHub Actions Inactive
@lokesh-bitgo

Copy link
Copy Markdown
Contributor

@claude Please do a thorough review of this PR.

Focus especially on:

  • any bugs or incorrect logic in the changes
  • whether these changes could impact existing flows or cause regressions
  • whether the implementation is aligned with the requirement/design
  • whether the changes are correct and complete
  • missing edge cases, validation gaps, and test coverage gaps

Please call out concrete issues clearly and separate them by severity if possible.

@lokesh-bitgo

Copy link
Copy Markdown
Contributor

@claude

@kisslove-dewangan

Copy link
Copy Markdown
Contributor Author

note: API spec breaking is intentional as I've confirmed from change owner, thread: https://bitgo.slack.com/archives/C057BHBRG4B/p1779958910469849

@kisslove-dewangan kisslove-dewangan force-pushed the WCI-242-add-eddsa-mpcv2-smc-utils branch from c51a674 to a7fd39f Compare May 29, 2026 05:56
@kisslove-dewangan kisslove-dewangan temporarily deployed to breaking-changes-override May 29, 2026 06:04 — with GitHub Actions Inactive

@lokesh-bitgo lokesh-bitgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Please add happy path test for the keyGenRound2 (enterprise) enterprise wrapper in follow up PR.

@kisslove-dewangan kisslove-dewangan dismissed Marzooqa’s stale review May 29, 2026 14:52

all feedback incorporated

@kisslove-dewangan kisslove-dewangan deployed to breaking-changes-override May 29, 2026 14:52 — with GitHub Actions Active
@kisslove-dewangan kisslove-dewangan merged commit b7c91fb into master May 29, 2026
35 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants