feat: add eddsa MPCv2 SMC utils#8845
Conversation
Marzooqa
left a comment
There was a problem hiding this comment.
Overall structure is correct — the 2-round key-gen flow (no round 3) is intentionally different from ECDSA because MPS EdDSA DKG only requires 2 BitGo rounds. uploadClientKeys is a faithful copy of the ECDSA version. Three issues below; one is a potential runtime failure on every call.
No tests added. The ECDSA MPCv2SMCUtils also has no unit tests, but this is still a gap — at minimum keyGenRound1BySender and keyGenRound2BySender should have state-assertion failure tests and a happy-path test using a stub sender.
e84788c to
c51a674
Compare
|
@claude Please do a thorough review of this PR. Focus especially on:
Please call out concrete issues clearly and separate them by severity if possible. |
|
note: API spec breaking is intentional as I've confirmed from change owner, thread: https://bitgo.slack.com/archives/C057BHBRG4B/p1779958910469849 |
c51a674 to
a7fd39f
Compare
lokesh-bitgo
left a comment
There was a problem hiding this comment.
Overall looks good. Please add happy path test for the keyGenRound2 (enterprise) enterprise wrapper in follow up PR.
TICKET: WCI-242