Temp [ improve worker observability ]#109
Open
bKP451 wants to merge 2 commits into
Open
Conversation
6b615b8 to
0101b39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don’t give crayons to more kids than the box has.
Summary
Improve
Delayed::Worker#work_offobservability and failure handling around worker thread setup.What Changed
work_offjob_sayperformfrom those that happen after it startsWhy
The worker previously had two observability gaps:
work_offdid not log enough detail to show where a batch was in the reserve and dispatch flowThis change makes worker execution easier to trace and improves behavior when a thread fails before the job body starts running.
Behavior
debug-level logs for thework_offloopperformhas started