Skip to content

Update mailpit version to 1.30.1 in configuration file#29

Open
N6REJ wants to merge 1 commit into
mainfrom
1.30.1
Open

Update mailpit version to 1.30.1 in configuration file#29
N6REJ wants to merge 1 commit into
mainfrom
1.30.1

Conversation

@N6REJ
Copy link
Copy Markdown
Contributor

@N6REJ N6REJ commented May 29, 2026

No description provided.

@N6REJ N6REJ added enhancement ✨ Improve program Security 🔐 Security issue labels May 29, 2026
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Add mailpit 1.30.1 configuration and update bundle version

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add mailpit 1.30.1 configuration file with SMTP and web settings
• Update bundle release version to 2026.3.5
Diagram
flowchart LR
  A["New mailpit 1.30.1 config"] -- "defines version and ports" --> B["bearsampp.conf"]
  C["build.properties"] -- "release version updated" --> D["2026.3.5"]

Loading

Grey Divider

File Changes

1. bin/mailpit1.30.1/bearsampp.conf ⚙️ Configuration changes +6/-0

Create mailpit 1.30.1 configuration file

• New configuration file created for mailpit 1.30.1
• Defines mailpit executable, web root, UI port (8025), SMTP port (25), and listen address
 (127.0.0.1)

bin/mailpit1.30.1/bearsampp.conf


2. build.properties ⚙️ Configuration changes +1/-1

Update bundle release version number

• Update bundle release version from 2026.4.19 to 2026.3.5

build.properties


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented May 29, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Action required

1. Release version regressed 🐞 Bug ≡ Correctness
Description
build.properties changes bundle.release to 2026.3.5, which is used by Gradle to set the project
version and to build the output directory and archive filename suffix for every bundle build. This
will generate artifacts like bearsampp-mailpit-<ver>-2026.3.5.7z that no longer match existing
published naming (e.g., 1.29.7 is published with -2026.4.19.7z), creating inconsistent/broken
release outputs.
Code

build.properties[2]

Evidence
The build reads bundle.release from build.properties into bundleRelease and uses it as the
Gradle project version and in the archive output path/filename. The repo’s releases.properties
already references artifacts whose filenames include a newer release suffix (e.g., 1.29.7 ends
with -2026.4.19.7z), so setting bundle.release to 2026.3.5 will produce mismatched artifact
names/paths versus what’s published.

build.gradle[33-52]
build.gradle[725-737]
releases.properties[4-5]
build.properties[1-4]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`build.properties` regresses `bundle.release` from a newer value to `2026.3.5`. The Gradle build uses `bundle.release` both as the Gradle project `version` and as part of the output path + archive filename, so this change will rename all produced artifacts and place them under the wrong release folder.

### Issue Context
This repo already has published artifact URLs in `releases.properties` that include newer `bundle.release` suffixes (e.g., `-2026.4.19.7z` for Mailpit `1.29.7`). With the regressed `bundle.release`, rebuilding any version will produce a different filename that does not correspond to those published URLs.

### Fix Focus Areas
- build.properties[1-4]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Comment thread build.properties
@@ -1,4 +1,4 @@
bundle.name = mailpit
bundle.release = 2026.4.19
bundle.release = 2026.3.5
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Release version regressed 🐞 Bug ≡ Correctness

build.properties changes bundle.release to 2026.3.5, which is used by Gradle to set the project
version and to build the output directory and archive filename suffix for every bundle build. This
will generate artifacts like bearsampp-mailpit-<ver>-2026.3.5.7z that no longer match existing
published naming (e.g., 1.29.7 is published with -2026.4.19.7z), creating inconsistent/broken
release outputs.
Agent Prompt
### Issue description
`build.properties` regresses `bundle.release` from a newer value to `2026.3.5`. The Gradle build uses `bundle.release` both as the Gradle project `version` and as part of the output path + archive filename, so this change will rename all produced artifacts and place them under the wrong release folder.

### Issue Context
This repo already has published artifact URLs in `releases.properties` that include newer `bundle.release` suffixes (e.g., `-2026.4.19.7z` for Mailpit `1.29.7`). With the regressed `bundle.release`, rebuilding any version will produce a different filename that does not correspond to those published URLs.

### Fix Focus Areas
- build.properties[1-4]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program Security 🔐 Security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant