Conversation
Review Summary by QodoAdd mailpit 1.30.1 configuration and update bundle version
WalkthroughsDescription• Add mailpit 1.30.1 configuration file with SMTP and web settings • Update bundle release version to 2026.3.5 Diagramflowchart LR
A["New mailpit 1.30.1 config"] -- "defines version and ports" --> B["bearsampp.conf"]
C["build.properties"] -- "release version updated" --> D["2026.3.5"]
File Changes1. bin/mailpit1.30.1/bearsampp.conf
|
Code Review by Qodo
1. Release version regressed
|
| @@ -1,4 +1,4 @@ | |||
| bundle.name = mailpit | |||
| bundle.release = 2026.4.19 | |||
| bundle.release = 2026.3.5 | |||
There was a problem hiding this comment.
1. Release version regressed 🐞 Bug ≡ Correctness
build.properties changes bundle.release to 2026.3.5, which is used by Gradle to set the project version and to build the output directory and archive filename suffix for every bundle build. This will generate artifacts like bearsampp-mailpit-<ver>-2026.3.5.7z that no longer match existing published naming (e.g., 1.29.7 is published with -2026.4.19.7z), creating inconsistent/broken release outputs.
Agent Prompt
### Issue description
`build.properties` regresses `bundle.release` from a newer value to `2026.3.5`. The Gradle build uses `bundle.release` both as the Gradle project `version` and as part of the output path + archive filename, so this change will rename all produced artifacts and place them under the wrong release folder.
### Issue Context
This repo already has published artifact URLs in `releases.properties` that include newer `bundle.release` suffixes (e.g., `-2026.4.19.7z` for Mailpit `1.29.7`). With the regressed `bundle.release`, rebuilding any version will produce a different filename that does not correspond to those published URLs.
### Fix Focus Areas
- build.properties[1-4]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.