Feat /strike remove manual user#110
Open
CartucheraSB wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat: Add /strike remove-manual-user subcommand
The existing /strike remove command uses autocomplete to fetch all users with active strikes and then fetches each user's username individually. As it stands the command causes the autocomplete to fail, my suspicion is these fetches exceed Discord's 3 second autocomplete timeout.
Added a new remove-manual-user subcommand that takes a plain mention or ID instead of autocomplete for the user field allowing for a focused query on the user as it's usually used.
The subcommand maintains the existing logic by reusing the removeStrike handler.