Fix NOLINT parsing bug#7118
Closed
Chessing234 wants to merge 2 commits into
Closed
Conversation
After ShareData/ShareDiff, stale capacity_ can cause Reshape to skip reallocation while pointing at shared memory incorrectly. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
NOLINT(without a closing parenthesis is misparsed asNOLINT(*).Root cause: The regex
\bNOLINT(_NEXT_LINE)?\b(\([^)]*\))?uses an optional capturing group for the parenthesis block. When the closing parenthesis is missing, the optional group fails to match, but since it is optional, the overall match succeeds withgroup(2)asNone. This causes the script to treat it as a blanketNOLINTsuppression.Why fix is correct: By making the closing parenthesis itself optional inside the capturing group (
(\([^)]*\)?)?), a malformedNOLINT(successfully populatesgroup(2)with(. The subsequent logic then correctly processes it as an unrecognized category instead of suppressing all lint errors.