test: remove unused scratch tests from u4 and sysrap#336
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the u4 test area by removing several ad hoc/scratch test and probe files that are no longer referenced by the regular U4 test build/run flow, and trims stale commented debug code in U4SensorIdentifierDefault.
Changes:
- Removed unreferenced scratch tests/probes:
G4ThreeVectorTest.cc,FewPMT_test.cc,FewPMT_test.sh,U4SensorIdentifierDefault_test.cc. - Updated
u4/tests/CMakeLists.txtto stop buildingG4ThreeVectorTest. - Removed stale debug-only commented-out lines (and extra trailing whitespace) in
u4/U4SensorIdentifierDefault.h.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| u4/U4SensorIdentifierDefault.h | Removes stale commented debug scaffolding / trailing whitespace; no functional logic change. |
| u4/tests/CMakeLists.txt | Drops G4ThreeVectorTest.cc from TEST_SOURCES so it is no longer built. |
| u4/tests/U4SensorIdentifierDefault_test.cc | Removes an ad hoc standalone scratch test (no remaining references found). |
| u4/tests/G4ThreeVectorTest.cc | Removes a scratch probe executable (no remaining references found; also removed from CMake). |
| u4/tests/FewPMT_test.sh | Removes an ad hoc compile/run helper script (no remaining references found). |
| u4/tests/FewPMT_test.cc | Removes an ad hoc probe executable (no remaining references found). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR removes a few ad hoc test/probe files that are no longer part of the regular U4 test flow and have no remaining callers. Changes: - remove `u4/tests/G4ThreeVectorTest.cc` - remove `u4/tests/FewPMT_test.cc` - remove `u4/tests/FewPMT_test.sh` - remove `u4/tests/U4SensorIdentifierDefault_test.cc` - drop `G4ThreeVectorTest.cc` from `u4/tests/CMakeLists.txt` - remove stale debug-only commented code in `u4/U4SensorIdentifierDefault.h` No functional behavior change is intended.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
plexoos
changed the title
- delete `SProcTest`, `SLaunchSequenceTest`, `SOpticksVersionNumberTest`, and `libunwind_backtrace` - remove the dead retired-test entry from `sysrap/tests/CMakeLists.txt`
- delete ad hoc language and stdlib probe files from `sysrap/tests` - remove unused standalone experiments that were not part of CMake or test runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR broadens the original
u4test cleanup to also remove retired and standalone scratch/probe sources fromsysrap/tests.u4
G4ThreeVectorTest.ccFewPMT_test.ccandFewPMT_test.shU4SensorIdentifierDefault_test.ccG4ThreeVectorTest.ccentry fromu4/tests/CMakeLists.txtu4/U4SensorIdentifierDefault.hsysrap
UnwindTest.cc,SProcTest.cc,SLaunchSequenceTest.cc,SOpticksVersionNumberTest.cc, andlibunwind_backtrace.csysrap/tests/CMakeLists.txtConstExprTest.cc,GridSpecTest.cc,LongestCommonPrefixTest.cc,complex_norm_test.cc,convertor_test.cc,cpp_virtual_hidden_warning_test.cc,do_while_continue.cc,fitsInShort_test.cc,map_void_int.cc,pathtype_test.cc,rounding_nearbyint_test.cc,stamp32.cc,static_array.cc,string_viewTest.cc,using_test.cc,variable_size_object_may_not_be_initialized.cc, andvector_copy_if_test.ccNo functional behavior change is intended.