Skip to content

fix: 상세페이지 API 응답구조 수정#313

Merged
ParkSungju01 merged 2 commits into
developfrom
312-fix-api-응답구조-변경-및-디자인-수정
May 25, 2026

Hidden character warning

The head ref may contain hidden characters: "312-fix-api-\uc751\ub2f5\uad6c\uc870-\ubcc0\uacbd-\ubc0f-\ub514\uc790\uc778-\uc218\uc815"
Merged

fix: 상세페이지 API 응답구조 수정#313
ParkSungju01 merged 2 commits into
developfrom
312-fix-api-응답구조-변경-및-디자인-수정

Conversation

@ParkSungju01
Copy link
Copy Markdown
Contributor

@ParkSungju01 ParkSungju01 commented May 25, 2026

✨ 요약

동아리 상세페이지 API 응답구조 수정
상단 nav 텍스트 디자인 수정



😎 해결한 이슈



Summary by CodeRabbit

릴리스 노트

  • 개선 사항
    • 동아리 상세 페이지의 브레드크럼 네비게이션 스타일을 개선했습니다.
    • 동아리 기본 정보 섹션의 표시 방식을 간소화했습니다.
    • 동아리 모집 정보 표시 로직을 정리했습니다.

Review Change Stack

@ParkSungju01 ParkSungju01 linked an issue May 25, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

Warning

Review limit reached

@ParkSungju01, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 55 minutes and 30 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c8d9288-1ffe-428b-9df1-a0667f541c21

📥 Commits

Reviewing files that changed from the base of the PR and between 1a6b59c and 86d0e5c.

📒 Files selected for processing (1)
  • apps/web/src/pages/ClubDetail/index.tsx

Walkthrough

API 응답 인터페이스 ClubDetailResponse에서 topic 필드를 추가하고 memberCount, recruitment 필드 및 Recruitment 타입을 제거합니다. 이에 따라 ClubDetail 페이지에서 제거된 필드의 사용을 정리하고, 날짜 포맷팅과 모집시기 파생값 계산 로직을 제거하며, 브레드크럼, description, 모집시기 영역의 렌더링을 조정합니다.

Possibly related PRs

  • BCSDLab/KONECT_FRONT_END#309: 동일한 ClubDetailResponse 스키마와 ClubDetail 페이지의 렌더링 로직을 같은 영역에서 변경하고 있어 중복이나 충돌 가능성이 있습니다.
  • BCSDLab/KONECT_FRONT_END#189: 제거된 memberCount 필드가 ClubMemberTab 등에서 사용되고 있어 영향도 확인이 필요합니다.

Suggested reviewers

  • ff1451
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 API 응답구조 수정이라는 주요 변경사항을 명확하게 요약하고 있습니다.
Linked Issues check ✅ Passed PR의 코드 변경이 #312 이슈의 목표인 동아리 상세정보 API 응답구조 수정(topic 필드 추가, memberCount/recruitment 제거)을 충족합니다.
Out of Scope Changes check ✅ Passed ClubDetail 컴포넌트의 렌더링 로직 정리가 API 응답구조 변경에 따른 필연적인 UI 수정으로 보여 대체로 범위 내입니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 312-fix-api-응답구조-변경-및-디자인-수정

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
apps/web/src/pages/ClubDetail/index.tsx (1)

102-104: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

"모집시기" 섹션이 불완전합니다.

라벨만 있고 실제 내용이 렌더링되지 않습니다. recruitment 필드가 제거되었으므로:

  1. 이 섹션을 완전히 제거하거나
  2. 새로운 API 필드(예: topic)를 활용하여 대체 콘텐츠를 표시해야 합니다.
🛠️ 섹션 제거 제안
               <div className="flex items-center gap-10">
                 <h2 className="text-text-500 text-[20px] font-semibold">한줄소개</h2>
                 <p className="text-text-900 text-[20px] font-semibold">{clubDetail.description}</p>
               </div>
-              <div className="flex gap-10">
-                <h2 className="text-text-500 text-[20px] font-semibold">모집시기</h2>
-              </div>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/pages/ClubDetail/index.tsx` around lines 102 - 104, The "모집시기"
label block in the ClubDetail component (index.tsx) is orphaned because the
recruitment field was removed; locate the div containing the h2 with text "모집시기"
and either remove that entire section or replace it to render a valid API field
(e.g., use the new topic field such as club.topic or props.club.topic), ensuring
you add a null/undefined guard and sensible fallback text; update any related
imports/props if you switch to rendering topic so the component receives that
field.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@apps/web/src/pages/ClubDetail/index.tsx`:
- Around line 102-104: The "모집시기" label block in the ClubDetail component
(index.tsx) is orphaned because the recruitment field was removed; locate the
div containing the h2 with text "모집시기" and either remove that entire section or
replace it to render a valid API field (e.g., use the new topic field such as
club.topic or props.club.topic), ensuring you add a null/undefined guard and
sensible fallback text; update any related imports/props if you switch to
rendering topic so the component receives that field.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 002f1183-189d-415e-8f6f-c58561bb1888

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca58ac and 1a6b59c.

📒 Files selected for processing (2)
  • apps/web/src/apis/clubDetail/entity.ts
  • apps/web/src/pages/ClubDetail/index.tsx

@ParkSungju01 ParkSungju01 merged commit 600c92a into develop May 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] API 응답구조 변경 및 디자인 수정

1 participant