feat: CoopNotificationService 클래스 추가#2252
Open
Soundbar91 wants to merge 7 commits into
Open
Conversation
📝 WalkthroughWalkthroughThe PR refactors dining notification handling by introducing ChangesDining notification service extraction
Sequence DiagramsequenceDiagram
participant CoopEventListener
participant CoopNotificationService
participant NotificationSubscribeRepository
participant NotificationFactory
participant NotificationService
CoopEventListener->>CoopNotificationService: sendDiningSoldOutNotifications(dinningId, place, diningType)
CoopNotificationService->>NotificationSubscribeRepository: find subscribers by type and detail type
NotificationSubscribeRepository-->>CoopNotificationService: subscribers list
CoopNotificationService->>NotificationFactory: create sold-out notifications
NotificationFactory-->>CoopNotificationService: notification objects
CoopNotificationService->>NotificationService: pushNotifications(notifications)
NotificationService-->>CoopNotificationService: delivery complete
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/java/in/koreatech/koin/domain/notification/service/CoopNotificationService.java (1)
27-36: ⚡ Quick winAdd device token filtering to
sendDiningSoldOutNotificationsfor consistency.While the current code doesn't cause runtime errors (FcmClient handles null tokens gracefully),
sendDiningSoldOutNotificationsshould filter subscribers by device token presence likesendDiningImageUploadNotificationsdoes. This prevents unnecessary FCM calls for users without device tokens and maintains a consistent pattern across the service.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/in/koreatech/koin/domain/notification/service/CoopNotificationService.java` around lines 27 - 36, The method that builds sold-out notifications uses notificationSubscribeRepository.findAllBySubscribeTypeAndDetailType(...) and maps every subscribe to notificationFactory.generateSoldOutNotification(...), but it should first filter out subscribers whose User.deviceToken is null/empty (same pattern as sendDiningImageUploadNotifications) so we don't create/push notifications for users without tokens; update the stream to .filter(subscribe -> subscribe.getUser() != null && subscribe.getUser().getDeviceToken() != null && !subscribe.getUser().getDeviceToken().isBlank()) before the .map(...) and then call notificationService.pushNotifications(notifications) as before.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@src/main/java/in/koreatech/koin/domain/notification/service/CoopNotificationService.java`:
- Around line 27-36: The method that builds sold-out notifications uses
notificationSubscribeRepository.findAllBySubscribeTypeAndDetailType(...) and
maps every subscribe to notificationFactory.generateSoldOutNotification(...),
but it should first filter out subscribers whose User.deviceToken is null/empty
(same pattern as sendDiningImageUploadNotifications) so we don't create/push
notifications for users without tokens; update the stream to .filter(subscribe
-> subscribe.getUser() != null && subscribe.getUser().getDeviceToken() != null
&& !subscribe.getUser().getDeviceToken().isBlank()) before the .map(...) and
then call notificationService.pushNotifications(notifications) as before.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 12bbdf97-cc6b-4c94-b289-99b864a2eb37
📒 Files selected for processing (3)
src/main/java/in/koreatech/koin/domain/notification/eventlistener/CoopEventListener.javasrc/main/java/in/koreatech/koin/domain/notification/service/CoopNotificationService.javasrc/main/java/in/koreatech/koin/domain/notification/service/NotificationService.java
💤 Files with no reviewable changes (1)
- src/main/java/in/koreatech/koin/domain/notification/service/NotificationService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
CoopNotificationService 클래스 추가
💬 참고 사항
✅ Checklist (완료 조건)
Summary by CodeRabbit