fix(azure-monitor-opentelemetry): Resolve pylint errors (#48011)#48034
Open
JacksonWeber wants to merge 1 commit into
Open
fix(azure-monitor-opentelemetry): Resolve pylint errors (#48011)#48034JacksonWeber wants to merge 1 commit into
JacksonWeber wants to merge 1 commit into
Conversation
…zure#48011) Add inline disable for C4749 (networking-import-outside-azure-core-transport) on the `import httpx` statement in the http_httpx tracing sample, matching the existing convention used for `import requests` in http_requests.py. The remaining next-pylint errors originally reported in Azure#48011 (C4766 in the main package and lint issues in the browserSdkLoader tests) have since been resolved upstream; this rebased change addresses the only outstanding next-pylint failure for the package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 219ddb2e-a7c0-4d3c-9be9-0f098587dc09
JacksonWeber
requested review from
MSNev,
hectorhdzg,
jeremydvoss,
lzchen and
rads-1996
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #48011 — resolves the outstanding
next-pylint(4.0.6) failure forazure-monitor-opentelemetry.Change
C4749 (networking-import-outside-azure-core-transport)on theimport httpxstatement insamples/tracing/http_httpx.py, matching the existing convention already used forimport requestsinhttp_requests.py.Note
This branch was rebased onto the latest
main. The other errors originally reported in #48011 —C4766 (do-not-log-exceptions-if-not-debug)in the main package and lint issues in thebrowserSdkLoadertests — have since been resolved upstream, so the httpx sample is the only remaining next-pylint failure.Verification
next-pylint(pylint 4.0.6 + azure-pylint-guidelines-checker 0.5.7) on main package, tests, and samples → all 10.00/10, exit 0.black --checkpasses.