[ACR] az acr create: Add --endpoint-protocol and --data-endpoint-enabled parameters#33472
Open
johnsonshi wants to merge 1 commit into
Open
[ACR] az acr create: Add --endpoint-protocol and --data-endpoint-enabled parameters#33472johnsonshi wants to merge 1 commit into
johnsonshi wants to merge 1 commit into
Conversation
johnsonshi
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
northtyphoon and
terencet-dev
Add support for --endpoint-protocol and --data-endpoint-enabled parameters on az acr create, complementing the existing support on az acr update. - --endpoint-protocol: Allows creating a registry with IPv4AndIPv6 (dual-stack) endpoint protocol. Requires --data-endpoint-enabled true. - --data-endpoint-enabled: Allows enabling dedicated data endpoints at registry creation time instead of requiring a separate update call. - Added help text examples showing combined usage. - Added unit tests for both new parameters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
johnsonshi
force-pushed
the
johsh/acr-create-endpoint-protocol
branch
from
e49971b to
54697d5
Compare
johnsonshi
changed the title
az acr create: Add --endpoint-protocol parameter to support specifying the endpoint protocol at registry creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for
--endpoint-protocoland--data-endpoint-enabledparameters onaz acr create, complementing the existing support onaz acr update(added in #33089).Changes
--endpoint-protocol(Preview): Allows specifying the endpoint protocol (IPv4orIPv4AndIPv6) at registry creation time. Requires--data-endpoint-enabled truewhen usingIPv4AndIPv6.--data-endpoint-enabled: Allows enabling dedicated data endpoints at registry creation time instead of requiring a separateaz acr updatecall.az acr createandaz acr updatein the Network Rule argument group.@live_only()decorator.Testing
Unit Tests
azure-mgmt-monitorimport issue intest_acr_create_with_audits— not caused by this PR)test_acr_create_with_dual_stack_endpoints— creates with--data-endpoint-enabled true --endpoint-protocol IPv4AndIPv6, verifies outputtest_acr_create_with_data_endpoint— creates with--data-endpoint-enabled true, verifies outputDogfood Validation
All dogfood tests run in southeastasia region, resource group
johshacrdf, using the locally-built CLI against Dogfood (api-dogfood.resources.windows-int.net).Each test follows the pattern:
az acr create→az acr show→az acr update→az acr show, verifying state at each step.Round 1: Initial Endpoint Protocol Tests (before
--data-endpoint-enabledon create)These tests validated
--endpoint-protocolonaz acr createbefore DDE-on-create was added.johshacrdfsea1az acr create --sku Premium(default)az acr update --data-endpoint-enabled truethen--endpoint-protocol IPv4AndIPv6johshacrdfsea2az acr create --sku Premium --endpoint-protocol IPv4az acr update --data-endpoint-enabled true --endpoint-protocol IPv4AndIPv6then back to--endpoint-protocol IPv4johshacrdfsea3az acr create --sku Premium --endpoint-protocol IPv4Round 2: Comprehensive Test Matrix (with
--data-endpoint-enabledon create)Category A: Dedicated Data Endpoint (DDE) Only
az acr createaz acr showaz acr updateaz acr showjohshdfseadde1--sku Premium --data-endpoint-enabled truedataEndpointEnabled: true--data-endpoint-enabled falsedataEndpointEnabled: falsejohshdfseadde2--sku Premium(no DDE flag)dataEndpointEnabled: false--data-endpoint-enabled truedataEndpointEnabled: truejohshdfseadde3--sku Premium --data-endpoint-enabled falsedataEndpointEnabled: false--data-endpoint-enabled truedataEndpointEnabled: trueCategory B: Dual-Stack Endpoint Protocol Only
az acr createaz acr showaz acr updateaz acr showjohshdfsead1--sku Premium --endpoint-protocol IPv4endpointProtocol: IPv4,dataEndpointEnabled: false--data-endpoint-enabled true --endpoint-protocol IPv4AndIPv6endpointProtocol: IPv4AndIPv6,dataEndpointEnabled: truejohshdfsead2--sku Premium(no ep flag)endpointProtocol: IPv4,dataEndpointEnabled: false--data-endpoint-enabled true --endpoint-protocol IPv4AndIPv6endpointProtocol: IPv4AndIPv6,dataEndpointEnabled: truejohshdfsead3--sku Premium --data-endpoint-enabled true --endpoint-protocol IPv4AndIPv6endpointProtocol: IPv4AndIPv6,dataEndpointEnabled: true--endpoint-protocol IPv4endpointProtocol: IPv4,dataEndpointEnabled: trueCategory C: Combined DDE + Dual-Stack
az acr createaz acr showaz acr updateaz acr showjohshdfseab1--sku Premium --data-endpoint-enabled true --endpoint-protocol IPv4AndIPv6dataEndpointEnabled: true,endpointProtocol: IPv4AndIPv6--data-endpoint-enabled false --endpoint-protocol IPv4dataEndpointEnabled: false,endpointProtocol: IPv4johshdfseab2--sku Premium(default, no flags)dataEndpointEnabled: false,endpointProtocol: IPv4--data-endpoint-enabled true --endpoint-protocol IPv4AndIPv6dataEndpointEnabled: true,endpointProtocol: IPv4AndIPv6johshdfseab3--sku Premium --data-endpoint-enabled truedataEndpointEnabled: true,endpointProtocol: IPv4--endpoint-protocol IPv4AndIPv6→ show →--endpoint-protocol IPv4 --data-endpoint-enabled falsedataEndpointEnabled: false,endpointProtocol: IPv4both3 detail (multi-step):
az acr create -n johshdfseab3 --sku Premium --data-endpoint-enabled true→ DDE=true, ep=IPv4az acr show→ DDE=true, ep=IPv4 ✅az acr update --endpoint-protocol IPv4AndIPv6→ DDE=true, ep=IPv4AndIPv6az acr show→ DDE=true, ep=IPv4AndIPv6 ✅az acr update --endpoint-protocol IPv4 --data-endpoint-enabled false→ DDE=false, ep=IPv4az acr show→ DDE=false, ep=IPv4 ✅Summary
southeastasiaIPv4AndIPv6requiresdataEndpointEnabled: trueRelated PR
az acr update: Add--endpoint-protocolparameter to support specifying the endpoint protocol for the registry #33089 (added--endpoint-protocoltoaz acr update)