Quantum: Remove deprecated location parameter#9908
Open
s-ddavydenko wants to merge 14 commits into
Open
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
* Managed Network Fabric CLI updates for new 2026-01-15-preview API * Managed Network Fabric CLI updates for new 2026-01-15-preview API * NetworkCloud CLI for the 2026-05-01-preview API * NetworkCloud CLI for the 2026-05-01-preview API * retrigger checks
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=165822620&view=results Last commit: Azure@72ddb7f
* Fix workspace create, tested * Worspace set command improvements
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=165988604&view=results Last commit: Azure@f561f26
…zure#9901) * Fix --additional-data and --change-definition to accept free-form nested JSON The --additional-data argument was defined as AAZObjectArg with no child fields, causing 'Model AAZObjectArg has no field named safeFly' errors. The --change-definition details field had the same issue, rejecting ApiOperations payloads with 'no field named operations'. Changes: - Change additional_data from AAZObjectArg to AAZFreeFormDictArg - Change change_definition.details from AAZObjectArg to AAZFreeFormDictArg - Change corresponding AAZObjectType to AAZFreeFormDictType in builders and response schemas across create, update, show, and list - Add content injection for additionalData in custom.py (same pattern as changeDefinition) to work around AAZ builder serialization limitation - Add tests for SafeFly payload, links, and orchestration-tool arguments - Bump version to 1.0.0b2 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Retrigger CI (transient GitHub 403 incident on prior run) * Address PR nits: use 'is None' / 'is not None' for additional_data checks Per review feedback, replace truthiness checks with explicit None checks so that an explicitly provided empty dict {} is treated as a valid user-supplied value rather than being silently dropped. - _inject_additional_data_into_content: 'if not additional_data' -> 'is None' - ChangeRecordCreate.pre_operations: 'if additional_data' -> 'is not None' - ChangeRecordUpdate.pre_operations: same fix for consistency (duplicated pattern) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Henry Dai <henrydai@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=166044594&view=results Last commit: Azure@b145cb5
s-ddavydenko
changed the title
Collaborator
|
Quantum |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the deprecated --location/-l parameter from Azure Quantum CLI commands and updates the extension’s tests and help text to reflect the new command shapes.
Changes:
- Removed
locationparameters from several command operation functions (workspace,target,job). - Updated scenario/live tests to stop passing
-l/--location(and updated expected error/help strings accordingly). - Updated CLI help examples and added release notes documenting the breaking change.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/quantum/azext_quantum/tests/latest/test_quantum_workspace.py | Updates workspace tests to remove -l/--location from workspace set invocations. |
| src/quantum/azext_quantum/tests/latest/test_quantum_targets.py | Updates target scenario test to set workspace without -l/--location. |
| src/quantum/azext_quantum/tests/latest/test_quantum_jobs.py | Updates job tests to remove -l/--location and adjusts expected usage strings. |
| src/quantum/azext_quantum/operations/workspace.py | Removes location argument from workspace quotas and workspace set operation functions. |
| src/quantum/azext_quantum/operations/target.py | Removes location argument from target list operation function. |
| src/quantum/azext_quantum/operations/job.py | Removes location argument from multiple job operation functions and updates internal run -> submit call. |
| src/quantum/azext_quantum/_help.py | Updates CLI help examples to remove -l/--location. |
| src/quantum/azext_quantum/_breaking_change.py | Removes deprecation registrations now that --location is removed. |
| src/quantum/HISTORY.rst | Adds release notes entry documenting the removal of --location/-l. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated
--location/-lparameter from job submission related commands.Motivation
Now workspace initialization request ARM/ARG and gets location from there. The parameter was already marked deprecated and scheduled for removal.
Changes
--location/-lfromaz quantum jobcommand definitions and from the underlyingoperations/job.pyfunctions.--location.setup.py; added entry toHISTORY.rst.Testing
src/quantum/azext_quantum/tests/latestpass locally (pytest).