Turbo ACL Bug Fix#313
Open
DevanshG1 wants to merge 2 commits into
Open
Conversation
added 2 commits
June 8, 2026 11:55
linuxsmiths
reviewed
Jun 24, 2026
Comment on lines
+2155
to
+2156
| nfs_set_uid(nfs, ctx->uid); | ||
| nfs_set_gid(nfs, ctx->gid); |
Collaborator
There was a problem hiding this comment.
you may also want to set the supplementary groups for complete permission sanity, o/w some permissions granted via supplementary groups may not work.
Do check what supplementary groups are being sent in the RPC.
|
|
||
| do { | ||
| rpc_retry = false; | ||
| set_caller_credentials(); |
Collaborator
There was a problem hiding this comment.
the change to set the uid/gid in the RPC, from the fuse ctx is correct, just make sure you do it for all NFS command and none get missed out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the turbo client runs as a FUSE demon, it has a uid=0. When root squash is enabled, even though sattr3 has the correct uid/gid, it is not honored and the uid used is 0. To fix this i have called the setuid and setguid functions before each RPC dispatch