fix: mobile contest followers list shows blank#14316
Merged
Merged
Conversation
|
The `enabled` option was placed before `...options` spread, so a
caller passing `{ enabled: true }` (e.g. ContestFollowersModal) could
override the `!!eventId` guard and let the query run with a null
event id. Move the guard after the spread and combine with the
caller's enabled so the eventId check always wins.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dylanjeffers
force-pushed
the
fix/mobile-contest-followers-blank
branch
from
c7903c5 to
2de3c5f
Compare
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14316.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enabledoption inuseEventFollowerswas placed BEFORE the...optionsspread, so any caller passing an explicitenabled(e.g.ContestFollowersModalwith{ enabled: isOpen }) silently overrode the!!eventIdguard.enabledline AFTER the spread and combined the eventId guard with the caller's value:enabled: !!eventId && (options?.enabled ?? true). The eventId check now always wins, so the query can never run with a null event id.Test plan
{ enabled: isOpen })🤖 Generated with Claude Code