fix(contests): show skeletons only until feature flag resolves#14314
Open
dylanjeffers wants to merge 1 commit into
Open
fix(contests): show skeletons only until feature flag resolves#14314dylanjeffers wants to merge 1 commit into
dylanjeffers wants to merge 1 commit into
Conversation
The contests page disabled its remix-contests query while `useFeatureFlag(CONTESTS).isEnabled` was still `undefined`. Disabled queries report `isPending: true`, so skeletons stayed on screen for the full ~14s Optimizely cold-load. Start the query optimistically before the flag resolves; the existing `<Navigate to='/' />` still handles the flag-off case once it loads. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAllRemixContestsquery whileuseFeatureFlag(CONTESTS).isEnabledwas stillundefinedduring Optimizely's ~14s cold-load. Disabled queries reportisPending: true, so the skeleton state stayed on screen indefinitely on first paint.enabledon!isFlagLoaded || isContestsPageEnabled. The existing<Navigate to='/' />continues to redirect once the flag loads asfalse, so users without access still can't see contest data.Test plan
/contestswith Optimizely throttled — verify contest cards render as soon as the API responds rather than waiting on the flag.CONTESTSflag off — verify the page still redirects to/after the flag resolves.🤖 Generated with Claude Code