Pass maxFramesToRender to DSP at allocation time#38
Merged
Conversation
Closes #16. AudioKitAU already knows maximumFramesToRender from the host but never forwarded it into C++, so DSP kernels had no sanctioned way to pre-size scratch buffers at init time and had to infer the worst case from the first render's output buffer. Store the value as a member on DSPBase, set by allocateRenderResourcesDSP before init() is called. Subclasses opt in by reading maximumFramesToRender in their init() override — the virtual init(int, double) signature is unchanged, so existing overrides (including those in downstream projects) keep compiling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wtholliday
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16. AudioKitAU already knows maximumFramesToRender from the host but never forwarded it into C++, so DSP kernels had no sanctioned way to pre-size scratch buffers at init time and had to infer the worst case from the first render's output buffer.
Store the value as a member on DSPBase, set by allocateRenderResourcesDSP before init() is called. Subclasses opt in by reading maximumFramesToRender in their init() override — the virtual init(int, double) signature is unchanged, so existing overrides (including those in downstream projects) keep compiling.