[PWGLF] Feat/antin cex hist update#16313
Draft
FabiolaLP wants to merge 4 commits into
Draft
Conversation
FabiolaLP
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
lhusova,
maciacco,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
|
O2 linter results: ❌ 3 errors, |
github-actions
Bot
changed the title
Collaborator
|
Error while checking build/O2Physics/staging for 767bf57 at 2026-05-20 01:26: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 767bf57 at 2026-05-20 01:32: Full log here. |
vkucera
requested changes
May 22, 2026
Comment on lines
+17
to
+31
| #include <PWGLF/DataModel/LFAntinCexTables.h> | ||
|
|
||
| #include "PWGLF/DataModel/LFAntinCexTables.h" | ||
|
|
||
| #include "Common/DataModel/PIDResponseITS.h" | ||
| #include <Common/DataModel/PIDResponseITS.h> | ||
|
|
||
| #include <CommonConstants/MathConstants.h> | ||
| #include <DCAFitter/DCAFitterN.h> | ||
| #include <DetectorsBase/Propagator.h> | ||
| #include <Framework/AnalysisDataModel.h> | ||
| #include <Framework/AnalysisHelpers.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/HistogramRegistry.h> | ||
| #include <Framework/HistogramSpec.h> | ||
| #include <Framework/InitContext.h> | ||
| #include <Framework/OutputObjHeader.h> | ||
| #include <Framework/Logger.h> | ||
| #include <Framework/runDataProcessing.h> | ||
| #include <ReconstructionDataFormats/PID.h> | ||
| #include <ReconstructionDataFormats/Track.h> | ||
| #include <ReconstructionDataFormats/TrackParametrization.h> | ||
|
|
||
| #include <TDatabasePDG.h> | ||
| #include <TMCProcess.h> | ||
| #include <TMath.h> |
Collaborator
There was a problem hiding this comment.
This is wrong. How did you produce these changes?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out. I checked the current version in both my local branch and the GitHub branch, and the include block does not contain duplicated lines anymore. It may have been shown from an intermediate diff/formatting update.
Collaborator
There was a problem hiding this comment.
What do you mean? This is the current state of the PR.
Contributor
Author
There was a problem hiding this comment.
Could you please clarify which specific change in the include block you consider wrong?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the antineutron CEX analysis task and corresponding data model.
Main changes:
Removed obsolete histograms.
Added new histograms for updated analysis studies.
Updated the content of LFAntinCexTables.
Minor cleanup and consistency updates in the task output.
The task was rebuilt and tested successfully in a fresh O2Physics installation.