test(helix): PROBE-MANTISSA-FILL + PROBE-PHASE-1 — Wave-0 probes, 4/4 green#485
Conversation
|
Warning Review limit reached
More reviews will be available in 38 minutes and 53 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR documents probe findings for 2026-06-10 in a dated log entry and adds a comprehensive test suite validating that golden-mantissa point generation achieves superior bin fill metrics compared to uniform-random baselines, confirms CurveRuler determinism across independent constructions, and verifies arc permutation correctness for the stride-4-over-17 pattern. ChangesProbe Results and Validation Tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dacc3067ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for &seed in &SEEDS { | ||
| let (r_occ, r_max) = fill_metrics(random_disk_points(k, seed).into_iter()); | ||
| assert!( | ||
| g_occ >= r_occ, |
There was a problem hiding this comment.
The test declares the gate green only when golden “beats” every seeded baseline on both metrics, and the receipts in the doc/epiphany are used to justify the proposal as measured. With >= here (and the matching <= for max-bin just below), a later regression that merely ties any random baseline still passes while being reported as a win; that can falsely advance the Wave-0 probe. Make these comparisons strict (> for occupied and < for max-bin) or change the stated pass criterion to allow ties.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Caught — the prose said 'beats' but >=/<= silently admitted ties. Strict > and < shipped in the next commit. Measured numbers (k=256: 192 vs 141-150, 3 vs 5-6; k=1024: 208 vs 205-206, 7 vs 11) strictly satisfy the strict form, so the receipt embedded in PR OGAR#51's canon pin is unchanged; the gate just correctly RED's a future tie.
Surveyed PRs #471-#487. Three landed that materially affect my outstanding ask list: - #482 (merged): GUID canon + prefix routing knowledge doc — pins TWO-ALGEBRA RULE (sign=XOR, magnitude=bundle, never MergeMode::Xor) + helix CurveRuler stride-4-over-17 as bit-exact integer phase generator. Both are load-bearing receipts for substrate-addressing-v1. - #484 (merged): D-IDENTITY-2 ships entity_type↔NiblePath bijection in lance-graph-ontology registry. RESOLVES the Tier-1 'NiblePath scheme for FMA classes' ask — OGAR Phase 8 calls register_class_path() per FMA Class. - #485 (OPEN): PROBE-MANTISSA-FILL + PROBE-PHASE-1 both GREEN. The golden-mantissa placement leg of the substrate-addressing claim is now measured (not asserted): beats seeded random by ~30% at k=256 + half worst-case pile-up. CurveRuler bit-exactness verified over 20 path/depth pairs. Updated Decision 1 trigger: substrate-addressing-v1.md now files after #485 merges (not after D-HELIX-1 owner ping — they're actively probing). D-CESIUM-1 (mine — extend implicit_tiling.rs to consume helix::bounds) is the file-soonest deliverable. D-JC-1 still needs per-scene-class p calibration timeline.
… green
Two probes from OGAR/docs/INTEGRATION-TEST-PLAN.md Wave 0, run against
SHIPPED code only (zero non-test changes):
PROBE-MANTISSA-FILL (gate for the volumetric/field-edge proposal):
does the shipped golden-mantissa generator (HemispherePoint::lift,
azimuth n*phi, equal-area r=sqrt(u)) place k implicit centroids over
a 256x256 tile more uniformly than seeded uniform-random on the same
disk support? Metric: occupied in-disk bins (16x16) + max bin count;
golden must beat ALL THREE independent baseline seeds on BOTH metrics
at BOTH k=256 and k=1024 — no cherry-picking.
RESULT — GREEN:
k=256: golden occupied=192 max_bin=3 vs random 141-150 / 5-6
k=1024: golden occupied=208 max_bin=7 vs random 205-206 / 11
plus: zero empty interior bins (bin-center radius <= 0.9) at k=1024.
PROBE-PHASE-1 (Wave-0 row 1; D-QUANTGATE integer phase walk):
RESULT — GREEN: CurveRuler regeneration bit-exact across independent
constructions (20 (path,depth) pairs incl. u64::MAX); the
stride-4-over-17 arc is a full permutation from every one of the 17
start offsets.
Kill-conditions were declared before running (per the probe-first
plan): a red MANTISSA-FILL would have demoted the golden-placement leg
to an explicit centroid grid. It is green; the leg is measured.
Board hygiene: EPIPHANIES E-PROBE-MANTISSA-1 prepended in this commit
(numbers + the three remaining gates before VolumetricField leaves [H]).
https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY
AdaWorldAPI
force-pushed
the
claude/probe-mantissa-fill
branch
from
dacc306 to
a32cb17
Compare
Codex caught the wording-vs-code mismatch: PR body + EPIPHANIES say golden 'beats' every seed, but the asserts used >=/<= so a tie would pass while being reported as a win. Tightening to strict > and < matches the prose. The measured numbers (k=256: 192 vs 141-150, 3 vs 5-6; k=1024: 208 vs 205-206, 7 vs 11) strictly satisfy the strict form, so the receipt is unchanged. A future regression that merely ties would now correctly RED the probe. Inline comment cites the Codex review + EPIPHANIES for the audit trail. https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY
…conflicts Board prepend zones (AGENT_LOG, EPIPHANIES) auto-merged; no semantic overlap — main-side additions (#485 helix probe, #486 docs) reference none of the tombstoned emission identifiers (verified by grep: only intentional historical mentions in comments remain). https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY
2 participants
What this PR is
Two Wave-0 probes from
OGAR/docs/INTEGRATION-TEST-PLAN.md§1, run against SHIPPED code — both GREEN. One test file + one EPIPHANIES prepend (board hygiene in the same commit). Zero non-test changes.PROBE-MANTISSA-FILL — GREEN (the gate for the volumetric/field-edge proposal)
Does the shipped golden-mantissa generator (
HemispherePoint::lift— azimuthn·φ, equal-arear=√u) place k implicit centroids over a 256×256 tile more uniformly than seeded uniform-random on the same disk support?Golden beats all three independent baseline seeds on both metrics at both sample counts (pass criterion declared before running — no cherry-picking), plus zero empty interior bins (center-radius ≤ 0.9) at k=1024. The "golden mantissa places implicit centroids" leg of the volumetric-edge proposal is now measured, not asserted: ≈ +30% coverage and ≈ half the worst-case pile-up at k=256.
Kill-condition (declared in the test doc-comment): a red here would have demoted the golden-placement leg to an explicit centroid grid. It's green.
PROBE-PHASE-1 — GREEN (Wave-0 row 1; the D-QUANTGATE integer phase walk)
CurveRulerregeneration is bit-exact across independent constructions (20(path, depth)pairs incl.u64::MAX) — same address ⟹ same sequence, the property the deterministic-phase pin (OGAR/CLAUDE.md) stands on.Receipts ledger after this PR
Three probes have now been executed first-hand this session: HILBERT-L4 (13/13, ndarray #215), PHASE-1, MANTISSA-FILL. Remaining gates before the
VolumetricFieldedge-layout leaves[H]: PROBE-ATTN-EDGE · PROBE-SPLAT-PSD · PROBE-CASCADE-SPARSITY (all named with kill conditions in the OGAR canon pin, PR OGAR#51).Run:
cargo test --manifest-path crates/helix/Cargo.toml --test probe_mantissa_fill -- --nocapturehttps://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY
Summary by CodeRabbit
Tests
Documentation