chore: raise minimum Python to 3.10#24
Merged
Merged
Conversation
The 'str | None' / 'datetime | None' parameter annotations added in #21 are evaluated at import time and fail on 3.9 (PEP 604 union syntax needs 3.10+). 3.9 is EOL and the lowest we actually run is 3.10 (collect-stats CI), so bump requires-python to >=3.10 rather than adding __future__ annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #21 review: the
str | Noneannotations added toanalyze_stats.main()evaluate at import and raiseTypeErroron 3.9 (PEP 604 needs 3.10+), yetrequires-pythonstill claimed>=3.9.3.9 is EOL and the lowest interpreter we actually run is 3.10 (collect-stats CI matrix), so raise
requires-pythonto>=3.10. Re-locked; ruff/mypy/pytest green.