fix(android_installs): restrict zero filtering to trailing tail only#23
Merged
ErikBjare merged 1 commit intoJul 12, 2026
Conversation
Internal zeros in the install series are valid data (e.g. a mid-series reporting gap). The previous predicate dropped *any* zero row, which was only correct for the unfinalized-days case at the tail. Fix: collect all rows, then strip the trailing-zero suffix in a second pass. Matches the intent in the original comment and the Codex bot finding on PR ActivityWatch#19 (discussion_r3566750142).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug identified by the Codex bot in PR #19 review comment discussion_r3566750142.
Problem:
parse_report()filtered out any row with value"0", but the intent was to suppress only Play Store's unfinalized trailing days (which report as 0). An internal zero (e.g. 2026-07-06 in the rebuild) is silently dropped, creating a gap in the install series thatanalyze_stats._load_data()then interpolates over.Fix: Collect all rows, then strip only the trailing-zero suffix in a second pass. This preserves valid internal zeros while still suppressing Play's unfinalized-tail noise.