Skip to content

Implement sciml initialisation test cases#3175

Merged
BSnelling merged 5 commits into
mainfrom
bes/initialisation_sciml
Jun 2, 2026
Merged

Implement sciml initialisation test cases#3175
BSnelling merged 5 commits into
mainfrom
bes/initialisation_sciml

Conversation

@BSnelling
Copy link
Copy Markdown
Collaborator

Adding support and test cases for initialisation of neural networks: https://github.com/PEtab-dev/petab_sciml_testsuite/tree/main/test_cases/initialization

@BSnelling BSnelling requested a review from a team as a code owner June 1, 2026 09:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.37%. Comparing base (667b17b) to head (e8adf8c).

Files with missing lines Patch % Lines
python/sdist/amici/sim/jax/petab.py 90.90% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3175      +/-   ##
==========================================
- Coverage   78.14%   77.37%   -0.78%     
==========================================
  Files         317      317              
  Lines       20772    20803      +31     
  Branches     1484     1483       -1     
==========================================
- Hits        16232    16096     -136     
- Misses       4532     4699     +167     
  Partials        8        8              
Flag Coverage Δ
cpp 69.99% <2.94%> (-0.11%) ⬇️
cpp_python 36.86% <0.00%> (-0.06%) ⬇️
petab 46.89% <32.35%> (-0.03%) ⬇️
petab_sciml 15.15% <91.17%> (+0.13%) ⬆️
python 66.75% <2.94%> (-1.84%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/exporters/jax/nn.py 99.13% <ø> (ø)
...hon/sdist/amici/importers/petab/_petab_importer.py 87.78% <100.00%> (-0.26%) ⬇️
python/sdist/amici/sim/jax/petab.py 85.31% <90.90%> (+0.31%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread python/sdist/amici/sim/jax/petab.py Outdated
"""
mapping_df = self._petab_problem.mapping_df

def _lookup_mid(pname: str) -> str | None:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no such function in the petab base library?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. There is MappingTable.get but I'd have to iterate through the array of mapping tables in the petab problem so it's convenient to use themapping_df which concatenates everything in this case.

Comment thread python/sdist/amici/sim/jax/petab.py Outdated
@BSnelling BSnelling added this pull request to the merge queue Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
@BSnelling BSnelling added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit c2393b4 Jun 2, 2026
27 of 28 checks passed
@BSnelling BSnelling deleted the bes/initialisation_sciml branch June 2, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants