feat: add version headers and feedback API#19
Merged
Conversation
- Add X-SDK-Version and X-SDK-Type headers to all requests - Add feedback() and feedback_async() methods for reporting false positives - Fix Retry-After header parsing to handle HTTP-date format - Fix async client leak in close() when no event loop is running - Add FeedbackResult model This enables the cloud to track SDK versions and allows users to submit feedback on detection results to improve accuracy.
The async client cleanup was checking the private `_closed` attribute which doesn't exist on httpx.AsyncClient. This caused the guard to always return True, skipping cleanup and leaking connections. Use the public `is_closed` property instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-SDK-VersionandX-SDK-Typeheaders to all requests for cloud telemetryfeedback()andfeedback_async()methods for reporting false positives or confirming detectionsRetry-Afterheader parsing to handle both integer seconds and HTTP-date formatclose()when no event loop is runningFeedbackResultmodel and export__version__Changes
_version.pyclient.pymodels.pyFeedbackResultdataclass__init__.pyFeedbackResultand__version__Usage
Test plan