feat(cluster): enable GKE managed ML Diagnostics for GKE version >= 1.35.0-gke.3065000#1186
Merged
Merged
Conversation
scaliby
requested changes
Jun 10, 2026
scaliby
reviewed
Jun 10, 2026
scaliby
requested changes
Jun 11, 2026
scaliby
left a comment
Member
There was a problem hiding this comment.
Thanks for your changes! Two minor fixes to go.
….35.0-gke.3065000 This change introduces automated management and lifecycle optimization for GKE Managed Machine Learning Diagnostics on cluster creation. Specifically: 1. Standardizes PEP 440 version comparison via `is_gke_version_at_least()` with a central minimum requirement constant (`MANAGED_MLDIAGNOSTICS_MIN_GKE_VERSION = "1.35.0-gke.3065000"`). 2. Refactors `run_gke_cluster_create_command()` to dynamically append `--enable-managed-mldiagnostics` when `--managed-mldiagnostics` is requested and the planned GKE control plane version meets or exceeds the minimum threshold. 3. Bypasses legacy user-space prerequisite installations (`install_mldiagnostics_prerequisites()`) when creating or updating clusters on modern GKE versions. 4. Refines `--dry-run` simulation in `get_gke_server_config()` and `get_gke_node_pool_version()` to correctly evaluate user-supplied GKE versions (`--gke-version=X`) or default smoothly to "0", ensuring accurate simulation without breaking Golden Recipe verification.
scaliby
approved these changes
Jun 11, 2026
scaliby
left a comment
Member
There was a problem hiding this comment.
thanks for addressing my feedback! LGTM!
Merged
via the queue into
AI-Hypercomputer:main
with commit Jun 11, 2026
4baa812
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces automated management and lifecycle optimization for GKE Managed Machine Learning Diagnostics on cluster creation.
Specifically:
is_gke_version_at_least()with a central minimum requirement constant (MANAGED_MLDIAGNOSTICS_MIN_GKE_VERSION = "1.35.0-gke.3065000").run_gke_cluster_create_command()to dynamically append--enable-managed-mldiagnosticswhen--managed-mldiagnosticsis requested and the planned GKE control plane version meets or exceeds the minimum threshold.install_mldiagnostics_prerequisites()) when creating or updating clusters on modern GKE versions.--dry-runsimulation inget_gke_server_config()andget_gke_node_pool_version()to correctly evaluate user-supplied GKE versions (--gke-version=X) or default smoothly to "0", ensuring accurate simulation without breaking Golden Recipe verification.Issue
Correcting the behaviour of:
--managed-mldiagnosticsflagTesting
Have you performed any manual testing on your change? Yes
xpk cluster create with >= 1.35.0-gke.3065000:xpk cluster create with < 1.35.0-gke.3065000Have you verified use cases affected by goldens? Yes