Skip to content

perf(headers): don't render template string when delete header #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tkan145 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(headers): don't render template string when delete header #1586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gateway/src/apicast/policy/headers/headers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ local command_functions = {
local function run_commands(context, commands, header_type, ...)
for _, command in ipairs(commands) do
local command_func = command_functions[header_type][command.op]
local value = command.template_string:render(context)
local value
if command.op ~= 'delete' then
value = command.template_string:render(context)
end

command_func(command.header, value, ...)
end
Expand Down
Loading