fix: encode special characters in tag delete URL path

Fixes #675 #994

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jacalata

tableauserverclient/server/endpoint/resource_tagger.py

@@ -39,7 +39,7 @@ def _add_tags(self, baseurl, resource_id, tag_set):
 
     # Delete a resource's tag by name
     def _delete_tag(self, baseurl, resource_id, tag_name):
-        encoded_tag_name = urllib.parse.quote(tag_name)
+        encoded_tag_name = urllib.parse.quote(tag_name, safe="")
         url = f"{baseurl}/{resource_id}/tags/{encoded_tag_name}"
 
         try:
@@ -124,7 +124,7 @@ def delete_tags(self, item: T | str, tags: Iterable[str] | str) -> None:
             tag_set = set(tags)
 
         for tag in tag_set:
-            encoded_tag_name = urllib.parse.quote(tag)
+            encoded_tag_name = urllib.parse.quote(tag, safe="")
             url = f"{self.baseurl}/{item_id}/tags/{encoded_tag_name}"
             self.delete_request(url)
 

test/test_tagging.py

@@ -256,3 +256,27 @@ def test_tag_with_spaces_is_quoted_in_request() -> None:
     labels = {tag.get("label") for tag in root.findall(".//tag")}
     assert '"Yearly Sales"' in labels
     assert "simple" in labels
+
+
+@pytest.mark.parametrize(
+    "tag, expected_encoded",
+    [
+        ("tag#name", "tag%23name"),  # issue #675: hash must be percent-encoded
+        ("tag.name", "tag.name"),  # issue #994: dot is safe, no encoding needed
+        ("tag+name", "tag%2Bname"),  # plus must be percent-encoded
+        ("tag/name", "tag%2Fname"),  # slash must be percent-encoded (safe='' fix)
+        ("tag name", "tag%20name"),  # space must be percent-encoded
+    ],
+)
+def test_delete_tags_special_characters_encoded(get_server, tag, expected_encoded) -> None:
+    """Verify delete_tags percent-encodes special characters in the tag path segment."""
+    server = get_server
+    workbook = make_workbook()
+
+    with requests_mock.mock() as m:
+        m.delete(requests_mock.ANY, status_code=200)
+        server.workbooks.delete_tags(workbook, tag)
+        history = m.request_history
+
+    assert len(history) == 1
+    assert history[0].url.endswith(f"/tags/{expected_encoded}")