Skip to content

Commit 21d4481

Browse files
committed
Rename DefinitionsCacheConsumer to SegmentsProvider
Clearer name for the narrow interface that provides the set of segment names referenced by flag definitions. AI-Session-Id: 8708ddbc-41d6-47c9-bcb7-9d209ee25aeb AI-Tool: claude-code AI-Model: unknown
1 parent 1a1d6e6 commit 21d4481

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package io.split.storages;
22

3-
public interface SplitCacheCommons extends DefinitionsCacheConsumer {
3+
public interface SplitCacheCommons extends SegmentsProvider {
44
long getChangeNumber();
55
}

segment-commons/src/main/java/io/split/engine/segments/SegmentSynchronizationTaskImp.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.split.engine.segments;
22

33
import io.split.engine.common.FetchOptions;
4-
import io.split.storages.DefinitionsCacheConsumer;
4+
import io.split.storages.SegmentsProvider;
55
import io.split.storages.RuleBasedSegmentCacheConsumer;
66
import io.split.storages.SegmentCacheProducer;
77
import org.slf4j.Logger;
@@ -36,14 +36,14 @@ public class SegmentSynchronizationTaskImp implements SegmentSynchronizationTask
3636
private final SegmentCacheProducer _segmentCacheProducer;
3737
private final ScheduledExecutorService _scheduledExecutorService;
3838
private final TelemetryListener _telemetryListener;
39-
private final DefinitionsCacheConsumer _definitionsCacheConsumer;
39+
private final SegmentsProvider _segmentsProvider;
4040
private final RuleBasedSegmentCacheConsumer _ruleBasedSegmentCacheConsumer;
4141

4242
private ScheduledFuture<?> _scheduledFuture;
4343

4444
public SegmentSynchronizationTaskImp(SegmentChangeFetcher segmentChangeFetcher, long refreshEveryNSeconds, int numThreads,
4545
SegmentCacheProducer segmentCacheProducer, TelemetryListener telemetryListener,
46-
DefinitionsCacheConsumer definitionsCacheConsumer, ExecutorFactory executorFactory,
46+
SegmentsProvider segmentsProvider, ExecutorFactory executorFactory,
4747
ThreadFactory threadFactory,
4848
RuleBasedSegmentCacheConsumer ruleBasedSegmentCacheConsumer) {
4949
_segmentChangeFetcher = Objects.requireNonNull(segmentChangeFetcher);
@@ -57,7 +57,7 @@ public SegmentSynchronizationTaskImp(SegmentChangeFetcher segmentChangeFetcher,
5757

5858
_segmentCacheProducer = Objects.requireNonNull(segmentCacheProducer);
5959
_telemetryListener = Objects.requireNonNull(telemetryListener);
60-
_definitionsCacheConsumer = Objects.requireNonNull(definitionsCacheConsumer);
60+
_segmentsProvider = Objects.requireNonNull(segmentsProvider);
6161
_ruleBasedSegmentCacheConsumer = Objects.requireNonNull(ruleBasedSegmentCacheConsumer);
6262
}
6363

@@ -201,7 +201,7 @@ private void initialize(String segmentName) {
201201
}
202202

203203
private Set<String> getSegmentNames() {
204-
Set<String> names = new HashSet<>(_definitionsCacheConsumer.getSegments());
204+
Set<String> names = new HashSet<>(_segmentsProvider.getSegments());
205205
names.addAll(_ruleBasedSegmentCacheConsumer.getSegments());
206206

207207
return names;

segment-commons/src/main/java/io/split/storages/DefinitionsCacheConsumer.java renamed to segment-commons/src/main/java/io/split/storages/SegmentsProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
import java.util.Set;
44

5-
public interface DefinitionsCacheConsumer {
5+
public interface SegmentsProvider {
66
Set<String> getSegments();
77
}

0 commit comments

Comments
 (0)