From fee72ef05c882004661ad6e32001d1708e07436a Mon Sep 17 00:00:00 2001 From: FantasyTeddy Date: Fri, 5 Jun 2026 12:36:30 +0200 Subject: [PATCH 1/2] Generate XML documentation --- Directory.Build.props | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Directory.Build.props b/Directory.Build.props index c8e8f76..f7ed530 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -6,5 +6,7 @@ https://github.com/sharpbrick/powered-up https://github.com/sharpbrick/powered-up MIT + true + $(NoWarn);CS1591 \ No newline at end of file From c792c93feab701c84e24c8a7f3be08a4028ed2ad Mon Sep 17 00:00:00 2001 From: FantasyTeddy Date: Fri, 5 Jun 2026 12:36:48 +0200 Subject: [PATCH 2/2] Fix XML documentation issues --- src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEHelper.cs | 2 +- .../BlueGigaBLEPoweredUpBluetoothAdapater.cs | 2 +- .../BlueGigaBLEPoweredUpBluetoothService.cs | 2 ++ src/SharpBrick.PoweredUp.BlueGigaBLE/IBlueGigaLogger.cs | 2 ++ src/SharpBrick.PoweredUp/Deployment/DeploymentModelBuilder.cs | 3 +-- src/SharpBrick.PoweredUp/Deployment/HubExtensions.cs | 2 +- 6 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEHelper.cs b/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEHelper.cs index 180be19..3a4f235 100644 --- a/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEHelper.cs +++ b/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEHelper.cs @@ -107,7 +107,7 @@ public static byte[] UlongTo6ByteArray(ulong myulong) /// /// Convert a ulong into a BYte-Array /// - /// the ulong to be converted + /// the byte[] to be converted /// public static ulong ByteArrayToUlong(byte[] mybytes) { diff --git a/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothAdapater.cs b/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothAdapater.cs index 4d83eb4..e3d70d9 100644 --- a/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothAdapater.cs +++ b/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothAdapater.cs @@ -133,7 +133,7 @@ async void GAPScanResponseEvent(object sender, BleScanResponseReceivedEventArgs /// /// Get the device given by the bluetooth-address (ulong) and discover all services and their characteristics. The device is connected after this call! /// - /// + /// /// public async Task GetDeviceAsync(IPoweredUpBluetoothDeviceInfo bluetoothDeviceInfo) { diff --git a/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothService.cs b/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothService.cs index 08da121..1ae1d56 100644 --- a/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothService.cs +++ b/src/SharpBrick.PoweredUp.BlueGigaBLE/BlueGigaBLEPoweredUpBluetoothService.cs @@ -43,6 +43,8 @@ public class BlueGigaBLEPoweredUpBluetoothService : IPoweredUpBluetoothService, /// The service-UUID of this service /// The first handle under which the service has a characteristic /// The last handle under which the service has a characteristic + /// + /// public BlueGigaBLEPoweredUpBluetoothService(BlueGigaBLEPoweredUpBluetoothDevice device, Guid serviceUuid, ushort firstCharacterHandle, ushort lastCharacterHandle, ILogger logger, bool traceDebug) { Device = device ?? throw new ArgumentNullException(nameof(device)); diff --git a/src/SharpBrick.PoweredUp.BlueGigaBLE/IBlueGigaLogger.cs b/src/SharpBrick.PoweredUp.BlueGigaBLE/IBlueGigaLogger.cs index e77b989..d314423 100644 --- a/src/SharpBrick.PoweredUp.BlueGigaBLE/IBlueGigaLogger.cs +++ b/src/SharpBrick.PoweredUp.BlueGigaBLE/IBlueGigaLogger.cs @@ -18,6 +18,8 @@ public interface IBlueGigaLogger /// Writes the indented information of this object into the configured ILogger /// /// + /// + /// public Task LogInfosAsync(int indent = 0, string header = "", string footer = ""); /// /// Shall the LogInfoAsync really log diff --git a/src/SharpBrick.PoweredUp/Deployment/DeploymentModelBuilder.cs b/src/SharpBrick.PoweredUp/Deployment/DeploymentModelBuilder.cs index f26e3eb..725a351 100644 --- a/src/SharpBrick.PoweredUp/Deployment/DeploymentModelBuilder.cs +++ b/src/SharpBrick.PoweredUp/Deployment/DeploymentModelBuilder.cs @@ -53,8 +53,7 @@ public DeploymentModelBuilder AddHub(SystemType? hubType, Action /// Adds a hub to the model /// - /// - /// + /// /// private DeploymentModelBuilder AddHub(DeploymentHubModel hubModel) { diff --git a/src/SharpBrick.PoweredUp/Deployment/HubExtensions.cs b/src/SharpBrick.PoweredUp/Deployment/HubExtensions.cs index 8496bb2..8388468 100644 --- a/src/SharpBrick.PoweredUp/Deployment/HubExtensions.cs +++ b/src/SharpBrick.PoweredUp/Deployment/HubExtensions.cs @@ -31,7 +31,7 @@ public static async Task VerifyDeploymentModelAsync(this Hub self, Action /// - /// Builder infrastructure for the deployment model + /// Deployment Model /// public static async Task VerifyDeploymentModelAsync(this Hub self, DeploymentModel model) {