Skip to content

instance_key as categorical in PointsModel #160

@giovp

Description

@giovp

Unrelated to the above but related to instance_key. I think that the column specified by instance_key should never be categorical, so we should remove this line:

if not is_categorical_dtype(data[instance_key]):

Originally posted by @LucaMarconato in #158 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions