From cf814d26f243b145a48d5ffcdd55d6e7b9544afc Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Tue, 30 Jun 2026 23:03:37 +0200
Subject: [PATCH] [Privatization] Skip FinalizeTestCaseClassRector for classes
 without Test suffix

---
 .../Fixture/skip_without_test_suffix.php.inc             | 9 +++++++++
 .../Fixture/some_class.php.inc                           | 4 ++--
 .../Fixture/with_attribute_new_line.php.inc              | 4 ++--
 .../Rector/Class_/FinalizeTestCaseClassRector.php        | 5 +++++
 4 files changed, 18 insertions(+), 4 deletions(-)
 create mode 100644 rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/skip_without_test_suffix.php.inc

diff --git a/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/skip_without_test_suffix.php.inc b/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/skip_without_test_suffix.php.inc
new file mode 100644
index 00000000000..f0bde3c4356
--- /dev/null
+++ b/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/skip_without_test_suffix.php.inc
@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class SomeReusableHelper extends TestCase
+{
+}
diff --git a/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/some_class.php.inc b/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/some_class.php.inc
index 957997bb7dc..023fb37b736 100644
--- a/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/some_class.php.inc
+++ b/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/some_class.php.inc
@@ -4,7 +4,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 
 use PHPUnit\Framework\TestCase;
 
-class SomeClass extends TestCase
+class SomeClassTest extends TestCase
 {
 }
 
@@ -16,7 +16,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 
 use PHPUnit\Framework\TestCase;
 
-final class SomeClass extends TestCase
+final class SomeClassTest extends TestCase
 {
 }
 
diff --git a/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/with_attribute_new_line.php.inc b/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/with_attribute_new_line.php.inc
index d44c6e64f13..da8335c3c5c 100644
--- a/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/with_attribute_new_line.php.inc
+++ b/rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/with_attribute_new_line.php.inc
@@ -5,7 +5,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 use PHPUnit\Framework\TestCase;
 
 #[CoversClass(Advisor::class)]
-class WithAttributeNewLine extends TestCase
+class WithAttributeNewLineTest extends TestCase
 {
 }
 
@@ -18,7 +18,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 use PHPUnit\Framework\TestCase;
 
 #[CoversClass(Advisor::class)]
-final class WithAttributeNewLine extends TestCase
+final class WithAttributeNewLineTest extends TestCase
 {
 }
 
diff --git a/rules/Privatization/Rector/Class_/FinalizeTestCaseClassRector.php b/rules/Privatization/Rector/Class_/FinalizeTestCaseClassRector.php
index 0a8db64329d..f6efeeb0e88 100644
--- a/rules/Privatization/Rector/Class_/FinalizeTestCaseClassRector.php
+++ b/rules/Privatization/Rector/Class_/FinalizeTestCaseClassRector.php
@@ -74,6 +74,11 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // skip classes without "Test" suffix, as those are meant to be extended
+        if (! str_ends_with($className, 'Test')) {
+            return null;
+        }
+
         if (! $this->reflectionProvider->hasClass($className)) {
             return null;
         }